Closed Bug 1759255 Opened 2 years ago Closed 2 years ago

Increase spotlight padding to 40px

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
100 Branch
Iteration:
100.1 - March 1 - March 18
Tracking Flags:
Tracking Status
firefox99 + verified
firefox100 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1759255 - Increase spotlight padding to 40px r?mviar
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-beta+
Details | Review

Sounds like the narrowing from bug 1758187 was too much.

[Tracking Requested - why for this release]: Design says this will help the modal look more legitimate

status-firefox100: --- → affected
status-firefox99: --- → affected
tracking-firefox99: --- → ?
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33c3fd17f626
Increase spotlight padding to 40px r=mviar

https://hg.mozilla.org/mozilla-central/rev/33c3fd17f626

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

I‘ve verified this enhancement using the latest Firefox Nightly 100.0a1 (Build ID: 20220315091352) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

  • The spotlight padding is increased to 40px.
Status: RESOLVED → VERIFIED
status-firefox100: fixed → verified

:Mardak could you add a beta uplift request for this?

Flags: needinfo?(edilee)

Comment on attachment 9267492 [details]
Bug 1759255 - Increase spotlight padding to 40px r?mviar

Beta/Release Uplift Approval Request

  • User impact if declined: Spotlight modals can look less "legitimate"
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Open up asrouter devtools and show PEACE_OF_MIND_GLOBAL_ROLLOUT
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS change to increase padding
  • String changes made/needed: none
Flags: needinfo?(edilee)
Attachment #9267492 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9267492 [details]
Bug 1759255 - Increase spotlight padding to 40px r?mviar

Approved for 99.0b5. Thanks.

Attachment #9267492 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I‘ve verified this enhancement using Firefox Beta 99.0b5 (Build ID: 20220317190002) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

  • The spotlight padding is increased to 40px.
status-firefox99: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: