Closed
Bug 1759255
Opened 3 years ago
Closed 3 years ago
Increase spotlight padding to 40px
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
Sounds like the narrowing from bug 1758187 was too much.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]: Design says this will help the modal look more legitimate
|
||
Updated•3 years ago
|
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33c3fd17f626
Increase spotlight padding to 40px r=mviar
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
|
||
Comment 5•3 years ago
|
||
I‘ve verified this enhancement using the latest Firefox Nightly 100.0a1 (Build ID: 20220315091352) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.
- The spotlight padding is increased to 40px.
Status: RESOLVED → VERIFIED
|
|
||
Comment 6•3 years ago
|
||
:Mardak could you add a beta uplift request for this?
Flags: needinfo?(edilee)
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9267492 [details]
Bug 1759255 - Increase spotlight padding to 40px r?mviar
Beta/Release Uplift Approval Request
- User impact if declined: Spotlight modals can look less "legitimate"
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Open up asrouter devtools and show PEACE_OF_MIND_GLOBAL_ROLLOUT
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS change to increase padding
- String changes made/needed: none
Flags: needinfo?(edilee)
Attachment #9267492 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Updated•3 years ago
|
Flags: qe-verify+
|
|
||
Comment 8•3 years ago
|
||
Comment on attachment 9267492 [details]
Bug 1759255 - Increase spotlight padding to 40px r?mviar
Approved for 99.0b5. Thanks.
Attachment #9267492 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 9•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
QA Whiteboard: [qa-triaged]
|
|
||
Comment 10•3 years ago
|
||
I‘ve verified this enhancement using Firefox Beta 99.0b5 (Build ID: 20220317190002) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.
- The spotlight padding is increased to 40px.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•