1759356 - Status bar color is light while using dark theme (Kubuntu doesn't ship with Adwaita-dark theme)

Status: RESOLVED MOVED

(Firefox :: Theme, defect)

Description

[serfreeman1337]

Attachment: statusbar_dark_issue.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

1. Enable "Dark" theme in Firefox.
2. Hower over link to observe status bar.

Actual results:

Status bar color is light and doesn't match dark theme.

Expected results:

Status bar color should be dark to match dark theme.

Additional info:
KDE v5.24.3 with X11
The only way to get status bar in dark color is to switch theme to "Breeze Dark" and then relogin.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alin Ilea, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0

Hi,

I have tested your issue on Release 98, Beta 99 and the latest Nightly build 100.0a1 (2022-03-24) and could not reproduce it using Ubuntu 20, X11. On my end, the status bar color is dark, matching the dark theme enabled.
If the issue is still reproducible on your end, can you please retest this using the latest Nightly build (https://nightly.mozilla.org/) using a new clean Firefox profile (https://goo.gl/AWo6h8) to eliminate the potential causes?

Thanks for the report.

Comment 3

[serfreeman1337]

Hello,

Yes, I'm still able to reproduce this issue with Nightly build 20220323214810 and new profile. This bug's also reproducible with Kubuntu 21.10.
Only way to get dark status bar is too set Appearance -> Global Theme -> Colours to "Breeze Dark"

Firefox theme: Dark
about:support reports "OS Theme" is "Breeze / Adwaita-dark"

KDE Appearance:
Application style: Breeze
Plasma Style: Breeze Dark
Colours: Breeze Classic

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Dão Gottwald [:dao]]

Emilio, any idea what could be going on here? We've switched to using -moz-content-prefers-color-scheme in bug 1751243.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I can't repro on KDE on Fedora 36 fwiw, but can try the Kubuntu version mentioned in comment 3. Can you attach the output of running firefox with MOZ_LOG=LookAndFeel:5 in the environment? Also, is there something in ~/.config/gtk-3.0 that could tamper with the Adwaita dark theme?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Also, if on Nightly, with clean profile (so, system theme) you create an about:config entry for ui.systemUsesDarkTheme with value 1, do you also get a white statusbar?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Ah, I could repro on a Kubuntu 21.10 VM. The issue is that Adwaita-dark doesn't even exist there. We literally don't have any dark GTK theme to fall back and get the colors from.

Reporter, can you confirm that running sudo apt install gnome-themes-extra (which should include Adwaita-dark) fixes it for you? It does for me.

Olivier, is there any chance we could include that by default with Firefox? Otherwise we can't offer a great experience when users choose a Firefox theme that doesn't match the color scheme of the GTK theme.

Also, there's a lot of other apps that are broken, for example the "Dark theme" checkbox of the gtk3-widget-factory application doesn't work by default on Kubuntu, which is unfortunate.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Btw, an even better fix would be for the breeze gtk theme to react to gtk-application-prefers-dark-theme (https://bugs.kde.org/show_bug.cgi?id=448877)

Comment 10

[serfreeman1337]

Can confirm that installing gnome-themes-extra package solved this issue and now status bar is dark (menus and dropdowns too).

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Thanks, I think this is not really a Firefox bug then, there's not much we can do if there's no GTK dark theme available. We could hardcode a bunch of the adwaita dark colors, but that still wouldn't be enough because we'd still draw native widgets using adwaita light, causing contrast issues.

Hopefully Olivier can help or point us at where to report the enhancement request for Kubuntu to install that package hopefully by default.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

(One day i should try to clone myself and try to fix the KDE bug reported above, that would be an even better fix)

Comment 13

[Olivier Tilloy]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #11)

Hopefully Olivier can help or point us at where to report the enhancement request for Kubuntu to install that package hopefully by default.

I would suggest filing a bug at https://bugs.launchpad.net/ubuntu/+source/kubuntu-meta/+filebug to request the additional dependency (probably a recommends, not an actual depends).

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Thanks Olivier!