17594 - view source doesn't color end of internal subset properly

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION: view source colors the DOCTYPE green, including all of the internal
subset except the final "]>".

STEPS TO REPRODUCE:
 * load attachment
 * view source

RESULTS:
 * the "]>" on its own line (the 10th) should be green and italic, but it's not.

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-10-29-10-M11

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test case described in bug

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Lowering to trivial.

Comment 3

[rickg]

Harish, this bug shows that you're trying to read an XML doctype Decl as a
comment. (This clearly cannot work in this case because of the entity def's).
We'll have to implement a doctype handler.

Comment 4

[Dan Rosen]

Not sure if this bug is as trivial as you think. Check out all the CDATA
sections in http://www.w3.org/TR/1999/PR-xslt-19991008.xml -- they're all
pretty messed-up colorwise.

Comment 5

[harishd]

Added code to parse DOCTYPE content correctly.    Marking FIXED.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified fixed, 1999-11-22-08-M12.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

CDATA sections issue spun off as bug 19923.