1759469 - touchpad pinch zoom not working on some devices like Dell Inspiron 3148 (workaround: set apz.windows.check_for_pan_gesture_conversion=false)

Status: UNCONFIRMED

(Core :: Panning and Zooming, defect, P3)

Description

[u703011]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0
Firefox for Android

Steps to reproduce:

Touchpad pinch zoom not working.

Actual results:

does not zoom with pinch. with ctrl + 2 finger up/ down it zooms.
pinch zoom on touchscreen works flawlessly.
Laptop is Dell Inspiron 3148

Expected results:

pinch zoom on touchpad should have worked exactly like touchscreen.
This bug was submitted earlier too, went to higher levels, you could not reproduce it. and till date no result.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Timothy Nikkel (:tnikkel)]

What happens when you pinch zoom in Chrome or Edge?

(In reply to krm from comment #0)

with ctrl + 2 finger up/ down it zooms.

When you do this do you get a smooth zoom in or a reflowing zoom with discrete steps?

This bug was submitted earlier too, went to higher levels, you could not reproduce it. and till date no result.

Do you remember the bug number or what account submitted it or other information we can use to find the old bug?

One other thing to check is in your Windows settings goto Touchpad, does it say "Your PC has a precision touchpad"?

Thanks

Comment 3

[u703011]

works perfect in edge.
withe edge its increment zoom, ie. 110,120 percent.
with ctrl + finger up down in firefox its incremental zoom.
with touchscreen in firefox, the zoom is as we have on mobiles. (don't know exactly what reflow means)
this bug was submitted earlier too. search my email, I think you got rid of it & and I of firefox!
pinch zoom with touchpad has no effect.
I have dell touchpad, all other apps are perfect.

Comment 4

[Botond Ballo [:botond]]

(In reply to krm from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0
Firefox for Android

To clarify: are you somehow running the Firefox for Android app on Windows?

Or does the bug report concern the regular desktop version of Firefox on Windows, and the above is just from filing the bug from an Android device?

(In reply to Timothy Nikkel (:tnikkel) from comment #2)

This bug was submitted earlier too, went to higher levels, you could not reproduce it. and till date no result.

Do you remember the bug number or what account submitted it or other information we can use to find the old bug?

Looks like bug 1687636. We did land a fix there, though by that time we were mostly corresponding with another user who was experiencing the issue (pbarrette). It's possible the issue had a different undelying cause in your case and wasn't fixed by the patch there.

Comment 5

[u703011]

children this is desktop version. i specifically edited desktop platform on win 10.
read specifics and don't be sloppy.

and how the hell does one run android version on windows?
give me.. maybe it'll be better!!

yes its bug 1687636. you chaps did nothing, and i left.
now you call it resolved without even the original bug reporter, that is me, confirming it resolved?
like i said, children don't be sloppy.

Chromium is messing up fonts in windows, and god knows what not.
either improve firefox, which has potential or ...

Today I noticed that Google maps is messed up in Firefox. But I cant keep filing bug reports, when you chaps cant do anything even after a year!!

Comment 6

[u703011]

ok i just did what the last comment in 1687636 asked to do in config..
pinch zoom worked with touchpad, but you can't expect the "world" to do this manually!!!

Comment 7

[Botond Ballo [:botond]]

(In reply to krm from comment #5)

this is desktop version

Thanks.

how ... does one run android version on windows?

I don't have a link handy but I've definitely heard talk of Windows supporting running Android apps; this is why I asked to be sure.

(In reply to krm from comment #6)

ok i just did what the last comment in 1687636 asked to do in config..
pinch zoom worked with touchpad,

Bug 1687636 comment 41 provides a summary of the issues affecting devices where the touchpad driver produces raw touch events, including the Dell Inspiron 3148. Issue (1) has been fixed in that bug, but issue (2) remains.

I had a theory in that bug, that perhaps our newer Direct Manipulation support resolves issue (2) and may allow us to make apz.windows.check_for_pan_gesture_conversion=false the default.

Could you check the following please: with the pref apz.windows.check_for_pan_gesture_conversion=false set (to allow touchpad pinch-zoom), are you able to scroll the green div on this page with a two-finger touchpad scroll gesture?

Comment 8

[u703011]

(In reply to Botond Ballo [:botond] from comment #7)

Could you check the following please: with the pref apz.windows.check_for_pan_gesture_conversion=false set (to allow touchpad pinch-zoom), are you able to scroll the green div on this page with a two-finger touchpad scroll gesture?

This is what I left in config.
apz.windows.check_for_pan_gesture_conversion=false
apz.windows.force_disable_direct_manipulation=false (default)

pinch zoom worked with touchscreen, touchpad. ctrl+2 finger incremental zoom worked with touchpad.

https://theres-waldo.github.io/mozilla-testcases/div.html, on this page too pinch zoom worked.

Comment 9

[Botond Ballo [:botond]]

(In reply to krm from comment #8)

https://theres-waldo.github.io/mozilla-testcases/div.html, on this page too pinch zoom worked.

Could you confirm if you can also scroll (not zoom) the green div on this page, with a two-finger touchpad gesture (i.e. by moving two fingers on the touchpad in the same direction)?

I ask because the reason apz.windows.check_for_pan_gesture_conversion=false is not the default is that, on affected devices, this codepath was known to break the ability to scroll non-root scrollable elements, such as the green div on that page, with the touchpad. (Basically, it fixed zooming but broke scrolling, which we considered to be worse.) I'd like to know if that's still the case.

Comment 10

[u703011]

(In reply to Botond Ballo [:botond] from comment #9)

(In reply to krm from comment #8)

https://theres-waldo.github.io/mozilla-testcases/div.html, on this page too pinch zoom worked.

Could you confirm if you can also scroll (not zoom) the green div on this page, with a two-finger touchpad gesture (i.e. by moving two fingers on the touchpad in the same direction)?

I ask because the reason apz.windows.check_for_pan_gesture_conversion=false is not the default is that, on affected devices, this codepath was known to break the ability to scroll non-root scrollable elements, such as the green div on that page, with the touchpad. (Basically, it fixed zooming but broke scrolling, which we considered to be worse.) I'd like to know if that's still the case.

yes two finger scroll is working in green zone.

Comment 11

[Mike Hoye [:mhoye]]

This is a polite reminder that Bugzilla is our professional working environment as much as it is our issue tracker, and we ask that people respect both the Bugzilla Etiquette Guidelines - https://bugzilla.mozilla.org/page.cgi?id=etiquette.html - as well as Mozilla's Community Participation Guidelines - https://www.mozilla.org/en-US/about/governance/policies/participation/ - if they intend to participate in Bugzilla, or any Mozilla forum.

Comment 12

[u703011]

(In reply to Mike Hoye [:mhoye] from comment #11)

This is a polite reminder that Bugzilla is our professional working environment as much as it is our issue tracker, and we ask that people respect both the Bugzilla Etiquette Guidelines - https://bugzilla.mozilla.org/page.cgi?id=etiquette.html - as well as Mozilla's Community Participation Guidelines - https://www.mozilla.org/en-US/about/governance/policies/participation/ - if they intend to participate in Bugzilla, or any Mozilla forum.

I am sorry if I used some harsh words. But sometimes you have to be harsh to wake people up. Do you really want chromium to remain the only engine?

Today I filed a Google Maps bug, and the response is, well I won't use any adjective. I am not getting paid to file bugs. I just want you the improve.

Comment 13

[u703011]

*To

Comment 14

[u703011]

Let me add that pinch zoom is buggy. You may feel like closing this bug report but Firefox has bugs somewhere or the other so people move to edge or opera. I have screenshots of Twitter feed where pinch zoom messed up the fonts. Didn't happen with zooming on touchscreen. Where do you want me to post the screenshots?

Comment 15

[u703011]

Ok, I uploaded the the default zoom & pinched zoom screenshots on these links
https://ibb.co/0F67yVh
https://ibb.co/WWfx1GM

Comment 16

[Botond Ballo [:botond]]

(In reply to krm from comment #10)

(In reply to Botond Ballo [:botond] from comment #9)

(In reply to krm from comment #8)

https://theres-waldo.github.io/mozilla-testcases/div.html, on this page too pinch zoom worked.

Could you confirm if you can also scroll (not zoom) the green div on this page, with a two-finger touchpad gesture (i.e. by moving two fingers on the touchpad in the same direction)?

I ask because the reason apz.windows.check_for_pan_gesture_conversion=false is not the default is that, on affected devices, this codepath was known to break the ability to scroll non-root scrollable elements, such as the green div on that page, with the touchpad. (Basically, it fixed zooming but broke scrolling, which we considered to be worse.) I'd like to know if that's still the case.

yes two finger scroll is working in green zone.

Thanks! Could I ask you to check one more thing please:

• Keep apz.windows.check_for_pan_gesture_conversion set to false
• Additionally change apz.windows.force_disable_direct_manipulation to true in about:config
• Restart browser
• Load https://theres-waldo.github.io/mozilla-testcases/div.html and check if you can still scroll the green div with a two-finger gesture

Thank you!

Comment 17

[Botond Ballo [:botond]]

(In reply to krm from comment #14)

I have screenshots of Twitter feed where pinch zoom messed up the fonts. Didn't happen with zooming on touchscreen. Where do you want me to post the screenshots?

Let's discuss that issue in a new bug please, so that we can keep this one focused on the issue of touchpad pinch-zoom not working by default (without setting apz.windows.check_for_pan_gesture_conversion=false) on some devices.

Comment 18

[u703011]

(In reply to Botond Ballo [:botond] from comment #16)

(In reply to krm from comment #10)

(In reply to Botond Ballo [:botond] from comment #9)

(In reply to krm from comment #8)

https://theres-waldo.github.io/mozilla-testcases/div.html, on this page too pinch zoom worked.

Could you confirm if you can also scroll (not zoom) the green div on this page, with a two-finger touchpad gesture (i.e. by moving two fingers on the touchpad in the same direction)?

I ask because the reason apz.windows.check_for_pan_gesture_conversion=false is not the default is that, on affected devices, this codepath was known to break the ability to scroll non-root scrollable elements, such as the green div on that page, with the touchpad. (Basically, it fixed zooming but broke scrolling, which we considered to be worse.) I'd like to know if that's still the case.

yes two finger scroll is working in green zone.

Thanks! Could I ask you to check one more thing please:

• Keep apz.windows.check_for_pan_gesture_conversion set to false
• Additionally change apz.windows.force_disable_direct_manipulation to true in about:config
• Restart browser
• Load https://theres-waldo.github.io/mozilla-testcases/div.html and check if you can still scroll the green div with a two-finger gesture

Thank you!

yes, 2 finger scroll worked.

Comment 19

[u703011]

just to add, i noticed that pinch zoom messes up google maps. cant select text/markers. Though we can zoom with scroll gesture, pinch surely messed it for me.

Comment 20

[Botond Ballo [:botond]]

(In reply to krm from comment #18)

Thanks! Could I ask you to check one more thing please:

• Keep apz.windows.check_for_pan_gesture_conversion set to false
• Additionally change apz.windows.force_disable_direct_manipulation to true in about:config
• Restart browser
• Load https://theres-waldo.github.io/mozilla-testcases/div.html and check if you can still scroll the green div with a two-finger gesture

Thank you!

yes, 2 finger scroll worked.

Thanks for testing.

This does mean that my theory that Direct Manipulation made the "pan gesture conversion" hack unnecessary, is wrong. There must be some other explanation for how your device is able to perform subframe scrolling with apz.windows.check_for_pan_gesture_conversion=false, while setting that pref to true breaks touchpad zooming. Until we understand this better, changing the default value of the pref to false would be risky (it would risk potentially breaking subframe scrolling on some other devices).

Comment 21

[Botond Ballo [:botond]]

(In reply to krm from comment #19)

just to add, i noticed that pinch zoom messes up google maps. cant select text/markers. Though we can zoom with scroll gesture, pinch surely messed it for me.

Do you still have apz.windows.force_disable_direct_manipulation set to true from the test in comment 16? If so, that may interfere with touchpad pinch-zooming, and resetting it to the default value of false should fix it.

Comment 22

[u703011]

(In reply to Botond Ballo [:botond] from comment #21)

(In reply to krm from comment #19)

just to add, i noticed that pinch zoom messes up google maps. cant select text/markers. Though we can zoom with scroll gesture, pinch surely messed it for me.

Do you still have apz.windows.force_disable_direct_manipulation set to true from the test in comment 16? If so, that may interfere with touchpad pinch-zooming, and resetting it to the default value of false should fix it.

after pinch zoom the cursor hover text highlight effect/select simply doesn't happen. with scroll zoom its ok.

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 24

[Botond Ballo [:botond]]

S3 for the issue described in the bug title (finding a way to get touchpad pinch-zoom working in the default configuration, i.e. without having to change the apz.windows.check_for_pan_gesture_conversion pref, on affected devices).

The issue described in comment 22 is best investigated in a separate bug, as it's not clear to me which configuration it affects.