1759557 - Add vp9 gbrp support

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: gbrp color shifing in FF98

720p.png.bt709.bt709.tv.gbrp.vp9.webm and 720p.png.bt709.bt709.pc.gbrp.vp9.webm render with incorrect color. This color shifting in the gbrp tests is causing confusion when landing other fixes to video decoding.

Comment 1

[Zaggy1024]

Attachment: Bug 1759557 - Fix support for decoding VP9 encoded with GBRP pixel format. r=alwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae5c32a54dd6
Fix support for decoding VP9 encoded with GBRP pixel format. r=alwu

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ae5c32a54dd6

Comment 4

[bszekely]

Backed out for causing reftest failures on incorrect_display_in_bytestream_vp9.html

Failure line: dom/media/test/reftest/incorrect_display_in_bytestream_vp9.html == dom/media/test/reftest/incorrect_display_in_bytestream_vp9-ref.html | image comparison, max difference: 16, number of differing pixels: 279035

Push with failures

Failure log

Backout link

Comment 5

[Zaggy1024]

I'm not sure if this patch should have affected that reftest, since that test video doesn't use GBRP format, but unfortunately I don't have a Mac to test this on. Is it possible this issue was present previously?

Whatever the case may be, though, I think this reftest is mainly there to determine whether the resolution is correct on the output, so number of differing pixels could probably be increased without any real consequences. :alwu do you think I should modify the reftest in this bug or we should push this as-is and then create a new bug for the reftest failure?

Comment 6

[Norisz Fay [:noriszfay]]

Backout has been merged to central: https://hg.mozilla.org/mozilla-central/rev/5fde45ddec26

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/957757f94115
Fix support for decoding VP9 encoded with GBRP pixel format. r=alwu

Comment 8

[Zaggy1024]

I believe the linked bug should cover the reason for the backout, clearing the unnecessary ni.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/957757f94115