175968 - Phoenix does not appear to pick up new themes after selecting them via tools->prefs->themes

Status: VERIFIED DUPLICATE of bug 172426

(Firefox :: Settings UI, defect)

Description

[Mobutu Sese Seko]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021021 Phoenix/0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021021 Phoenix/0.3

Mozilla supports selecting a new theme via the prefs->themes tab and then will
subsequently load this new theme successfully.

Phoenix does not succeed.  Prefs.js does acquire a new entry denoting the Modern 
theme should be used but Phoenx ignores this.  In fact, I cannot find any place
where Phoenix ever allows this switch to happen, though I do notice a chrome.dll
which I suspect contains a hardcoded preference for classic.jar.

In short, this works in Moz, should work in Phoenix (barring some drastic change
in supported features) and does not.

This is not bug 172426 or bug 174768.


Reproducible: Always

Steps to Reproduce:
1. Open tools menu and select prefs
2.  In prefs, select the themes/extensions choice on the left hand side
3.  Note the choice of two themes on the right hand side, classic at the top.
4.  Select Modern and click OK
5.  Quite Phoenix and restart.
6.  Note that Phoenix does not display the Modern theme and I seriously doubt
    It is now smart enough to revert to last known good theme though I would
    be gladly surprised if this indeed were the case and the problem lay with
    the Modern theme.


Actual Results:  
Prefs.js acquired an entry indicating the Modern theme should be used.
Restarting Phoenix shows no change.

Expected Results:  
Phoenx should have at least attempted to load the Modern theme.

Comment 1

[Marc Boullet]

*** This bug has been marked as a duplicate of 172426 ***

Comment 2

[Marc Boullet]

According to your description, this is indeed bug #172426.
Please, reopen if you disagree.

Comment 3

[Mobutu Sese Seko]

bug 172426 is to remove the Modern theme.  I'm reopenning this bug because no-one
has addressed this issue directly with any explanation of plans or objections.

Either the themes switch feature is supported in Phoenix or it is removed.  
Maybe a bug should be filed for that as well?

Comment 4

[Simon Paquet [:sipaq]]

>bug 172426 is to remove the Modern theme. I'm reopenning this bug because 
>no-one has addressed this issue directly with any explanation of plans or 
>objections.

The plan is obviously to remove the modern entry from the themes pref menu.

>Either the themes switch feature is supported in Phoenix or it is removed.  
>Maybe a bug should be filed for that as well?

Theme changing is supported in Phoenix. See http://themes.mozdev.org/phoenix/
for available themes. The only thing is, that the modern theme isn't packaged
with Phoenix anymore, therefore a theme switch doesn't work. This is only
logical, because what isn't there cannot work, of course. I agree, that there
should be some kind of a message, why Modern doesn't work, but this becomes
redundant, when the Modern entry in the themes section will be removed. I don't
think a bug is needed for this and this bug is clearly a duplicate of bug 172426
and should be marked as such.

*** This bug has been marked as a duplicate of 172426 ***

Comment 5

[Mobutu Sese Seko]

Well you are right as of the last day or two but the version of Phoenix I
experienced the problem on did have Modern and therefore was not a duplicate of
172426.

One problem with hijacking a bug to do something else is you lose the whole point
of a bugracking system which is to address directly problems reported.  Until
the themes stuff at mozdev went live THIS WEEK, there was no way to verify whether
or not switching themes worked.

Certainly there was nothing in any of the other bugs to address the direct issue
presented in the bug itself.  As far as I can see, 172426 is a bug to remove
Modern from the distribution which is what the bug says.

It would be unbelievably professional of folks to directly address the bug
reported rather than or in addition to hijacking the bug report selfishly.

Comment 6

[Simon Paquet [:sipaq]]

Mass verifiying of old duplicates.