1759816 - Too many "WARNING: '!aChild->IsContent()', file m:/fx64-dbg/dist/include\mozilla/EditorDOMPoint.h:534" in test log

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P5)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When I run ./mach mochitest editor/libeditor/tests, I got 586 instances of the warning.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1496320

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1759816 - Create `EditorDOMPointBase<PT, CT>::ParentPoint()` for avoiding warning spam caused by no necessary checks r=m_kato!

When setting a point, the child must be nsIContent. However, climbing up
the tree from a point with EditorDOMPointBase<PT, CT>, it may reach top of
the DOM tree (fragment). Then, we'd get a warning which wouldn't hit in
usual cases. Therefore, we should add new API to get parent point of an
EditorDOMPointBase<PT, CT> instance and it should check properly before
creating new instance.

Depends on D141195

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/976339473832
Create `EditorDOMPointBase<PT, CT>::ParentPoint()` for avoiding warning spam caused by no necessary checks r=m_kato

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/976339473832