1759952 - Some Context Menu Items Don't Work With Native GTK Context Menus

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[lolrepeatlol]

Attachment: Trying GTK native context menu items

Seemingly random context menu items don't work with native GTK menus.

Notably, copying and pasting text for example doesn't work. Save Page As... does not open a window to save the page. Still, other items like Reload work fine.

One thing I noticed was that while copying in the URL bar works, copying in webpages does not.

Attached is a (somewhat confusing, apologies) video of me trying various things with the GTK native context menus. Hopefully it gets the idea across

Comment 1

[Suraj]

I tried this, Send Page to Device is broken. also it is showing Back and Forward as text instead of Icons.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Please attach your about:support.
Thanks.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

This is expected, those menus need more work.

Comment 4

[Mr Beedell, Roke Julian Lockhart [:B.RJL]]

The menu presenting Back and Forward as text instead of Icons is desirable. Some of my grandparents really struggle to ascertain what your obscure iconography is, and for the sake of consistency and accessibility (think screen-readers) they should remain as text. No benefits are gained by their current implementation.

Comment 5

[cleomenezesjr]

Pela primeira vez decidi usar o widget.gtk.native-context-menus e acabo de encarar o mesmo problema.
Do menu context, de todas apções as unicas que funcionam são:

• Select All

Comment 6

[cleomenezesjr]

For the first time I decided to use widget.gtk.native-context-menus, and I just faced the same problem.
From the context menu, of all the options, the only ones that work are:

"Select All" and any option added by extensions

Btw, sorry for the latest incomplete portuguese message.

Comment 7

[Mr Beedell, Roke Julian Lockhart [:B.RJL]]

#c6

[e-mail], I don't think you need to apologize. We have access to translators. It is a shame that this feature hasn't seen much improvement.

Comment 8

[Davin Ockerby [:platinumlucario]]

Okay, two years later, reviving this issue by testing with latest Nightly 158.0a1 shows that GTK native context menus are still not functioning correctly.

https://share.firefox.dev/4yjz5Du

It can be very easily reproduced by attempting to right click on a tab and trying to select an option in the context menu will do absolutely nothing.

Lemme test with all add-ons disabled, and see if it changes anything...

https://share.firefox.dev/4Avq6Au

...Annnnnnd nope! Still doesn't. Unfortunately...

Possibly some line of code overriding the GTK native context menu event, perhaps?

Comment 9

[Thinker Li [:sinker]]

Please try this build to see if it works.
The menu has closed before running the command of the selected item.
It causes the command fails to run.
This build delays menu closing, and it should fix the issue.

[1] https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VJW3_QsCTQ2BttR1i9Br1Q/runs/0/artifacts/public/build/target.tar.xz

Comment 10

[Davin Ockerby [:platinumlucario]]

(In reply to Thinker Li [:sinker] from comment #9)

Please try this build to see if it works.
The menu has closed before running the command of the selected item.
It causes the command fails to run.
This build delays menu closing, and it should fix the issue.

[1] https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VJW3_QsCTQ2BttR1i9Br1Q/runs/0/artifacts/public/build/target.tar.xz

https://share.firefox.dev/4rtqwTI

Looks to me like the native GTK context menus are now working perfectly as intended in this build, seems ready to be merged into Nightly. Awesome work!

Comment 11

[Thinker Li [:sinker]]

Attachment: Bug 1759952 - [GTK] Run a native menu item's command before popuphiding r?stransky

GTK unmaps a menu before it activates the chosen item, so
NativeMenuGtk::OnUnmap() fired popuphiding and popuphidden before the item's
command ran. The hiding handlers tear down what the command needs: the
content area context menu sets gContextMenu to null (Copy Link, Save Page As
throw), the tab context menu clears contextTab, and in a text field the
removed spell check items rebuild the menu model, dropping the action of the
item being activated (Copy and Paste do nothing).

Fire the events from a runnable instead, so the command runs first, as it
does for XUL menus. Close() fires them right away, since a close requested by
code activates no item and the popup manager may show a new menu for the same
element right after it.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/635794860d63
https://hg.mozilla.org/integration/autoland/rev/12b75ec0bc83
[GTK] Run a native menu item's command before popuphiding r=stransky,gtk-reviewers,emilio

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/12b75ec0bc83