1760007 - 86.28 - 8.3% pdfpaint / pdfpaint + 4 more (Linux, OSX, Windows) regression on Mon March 14 2022

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push cd8d7e03fcb56f78a9f3c00b0d85c673b0bca30c. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
86%	pdfpaint	linux1804-64-shippable-qr	e10s fission stylo webrender	701.68 -> 1,307.10
81%	pdfpaint	linux1804-64-shippable-qr	e10s fission stylo webrender	730.05 -> 1,323.37
68%	pdfpaint	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	694.60 -> 1,163.53
20%	pdfpaint	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	526.47 -> 633.62
19%	pdfpaint	macosx1015-64-shippable-qr	e10s fission stylo webrender	528.57 -> 629.31
8%	pdfpaint	windows10-64-shippable-qr	e10s fission stylo webrender-sw	492.32 -> 533.20

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #33546 (as of Wed, 16 Mar 2022 13:41:04 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
31%	buzzfeed dcf	macosx1015-64-shippable-qr	fission warm webrender	330.56 -> 434.17
24%	imdb loadtime	windows10-64-shippable-qr	fission warm webrender	1,123.29 -> 1,390.21
9%	cnn-ampstories SpeedIndex	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	1,229.58 -> 1,343.67
8%	cnn-ampstories PerceptualSpeedIndex	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	958.58 -> 1,036.42
8%	cnn-ampstories fcp	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	1,125.73 -> 1,210.17
5%	cnn-ampstories LastVisualChange	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	1,318.12 -> 1,387.83
3%	cnn LastVisualChange	macosx1015-64-shippable-qr	fission warm webrender	1,325.00 -> 1,360.00

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	youtube ContentfulSpeedIndex	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	1,141.83 -> 979.50
12%	imdb ContentfulSpeedIndex	linux1804-64-shippable-qr	fission warm webrender	2,001.04 -> 1,761.75
12%	amazon-search LastVisualChange	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	5,549.58 -> 4,892.67
12%	wikipedia LastVisualChange	macosx1015-64-shippable-qr	fission warm webrender	903.33 -> 796.67
8%	amazon LastVisualChange	linux1804-64-shippable-qr	fission warm webrender	1,296.67 -> 1,186.67
...	...	...	...	...
3%	matrix-react-bench	windows10-64-shippable-qr	fission webrender	32.95 -> 31.89

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33546

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1755006

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Other changes look quite ok, but pdfpaint smells like it is measuring something a bit unexpected. Investigating.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1760007, use less frequent painting during page load only if there is something else to do.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8535cc3be690
use less frequent painting during page load only if there is something else to do. r=mstange

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8535cc3be690

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&series=mozilla-central,4060233,1,1&timerange=2592000 looks quite good.

Comment 8

[Andra Esanu (needinfo me)]

== Change summary for alert #33760 (as of Thu, 07 Apr 2022 03:50:39 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
58%	ts_paint_webext	windows10-64-shippable-qr	e10s fission stylo webrender	983.08 -> 412.58
57%	ts_paint	windows10-64-shippable-qr	e10s fission stylo webrender	950.58 -> 407.00
57%	ts_paint_webext	windows10-64-shippable-qr	e10s fission stylo webrender-sw	945.00 -> 406.08
57%	ts_paint	windows10-64-shippable-qr	e10s fission stylo webrender-sw	914.75 -> 395.00
57%	pdfpaint	linux1804-64-shippable-qr	e10s fission stylo webrender	1,310.95 -> 567.01
...	...	...	...	...
9%	pdfpaint	windows10-64-shippable-qr	e10s fission stylo webrender	591.30 -> 537.68

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33760