1760033 - Migrate aboutReader.properties to Fluent

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, task, P3)

Description

[Eemeli Aro [:eemeli]]

During startup, two strings only used by AboutReaderParent from aboutReader.properties are formatted: readerView.enter and readerView.enter.accesskey.

A few of the strings are formatted using PluralForm, a legacy API we'd like to drop.

As the readerView.close strings are also only used by this file, migrating all of them to Fluent with the properties-to-ftl tool should be relatively simple.

Comment 1

[Eemeli Aro [:eemeli]]

Attachment: Bug 1760033 - Convert aboutReader.html to Fluent. r=gijs!

The data included in the Reader:AddButton message used by SaveToPocket.jsm is slightly modified, as it now includes localization identifiers rather than a preformatted label.

Comment 2

[Eemeli Aro [:eemeli]]

Attachment: Bug 1760033 - Convert AboutReaderParent.jsm to Fluent. r=gijs!

Depends on D158575

Comment 3

[Eemeli Aro [:eemeli]]

Attachment: Bug 1760033 - Remove aboutReader.properties and its remaining strings as unused. r=gijs!

Depends on D158576

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f69b83013e1
Convert aboutReader.html to Fluent. r=Gijs,fluent-reviewers,geckoview-reviewers,flod,m_kato
https://hg.mozilla.org/integration/autoland/rev/f26056c61dc2
Convert AboutReaderParent.jsm to Fluent. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e54df449fbad
Remove aboutReader.properties and its remaining strings as unused. r=Gijs,geckoview-reviewers,m_kato

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing multiple failures

Backout link

Push with failures in ErrorResult.h // Failure log

Push with failures in browser_downloads_context_menu_delete_file.js // Failure log

Comment 6

[Eemeli Aro [:eemeli]]

Two messages were migrated to browser.ftl, while they're actually needed in menubar.ftl. For some reason, the error this causes is only logged in local tests as:

 0:06.26 GECKO(74081) JavaScript error: , line 0: uncaught exception: undefined
 0:06.26 GECKO(74081) JavaScript error: , line 0: uncaught exception: undefined

in the middle of Marionette setup log prints.

New try: https://treeherder.mozilla.org/jobs?repo=try&revision=392c1731e3c291800ad48cba6928571dee21ea2f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/776689ac2b69
Convert aboutReader.html to Fluent. r=Gijs,fluent-reviewers,geckoview-reviewers,flod,m_kato
https://hg.mozilla.org/integration/autoland/rev/0edfc7ab9988
Convert AboutReaderParent.jsm to Fluent. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/03a5ba4802be
Remove aboutReader.properties and its remaining strings as unused. r=Gijs,geckoview-reviewers,m_kato

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/776689ac2b69
https://hg.mozilla.org/mozilla-central/rev/0edfc7ab9988
https://hg.mozilla.org/mozilla-central/rev/03a5ba4802be