Closed Bug 1760077 Opened 3 years ago Closed 8 months ago

Intermittent netwerk/test/unit/test_channel_close.js | single tracking bug

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: jmaher, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [necko-triaged])

Attachments

(2 files, 1 obsolete file)

Bug 1760077 - Don't run test_channel_close.js on socket process because it's racy r=#necko
48 bytes, text/x-phabricator-request
Details | Review
Bug 1760077 - Fix racy test_channel_close.js r=#necko
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Severity: -- → S3
Whiteboard: [necko-triaged]

A large part of the failures are on socket process - I think the test is simply racy.
There are a few failures on non-socketprocess tests too, we should have a look at those if possible.

Flags: needinfo?(smayya)

Need to disable this test for the Socket process in general not just for Windows.

Flags: needinfo?(smayya)

Putting in priority-review to handle disabling the test, assuming we still want to do that.

Whiteboard: [necko-triaged] → [necko-triaged][necko-priority-review]

We should change this to be completely disabled on socket process.

Attachment #9381202 - Attachment is obsolete: true
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/30ac4dbda516 Don't run test_channel_close.js on socket process because it's racy r=necko-reviewers,kershaw

https://hg.mozilla.org/mozilla-central/rev/30ac4dbda516

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch

Reopening this bug as it's still happening as seen here.

Status: RESOLVED → REOPENED
status-firefox125: fixed → ---
Flags: needinfo?(valentin.gosu)
Resolution: FIXED → ---
Target Milestone: 125 Branch → ---

ChannelListener throws an exception if the channel gets closed unexpectedly.
Since this test was racing live_channels[1] vs local_channel, sometimes
the server would get closed before local_channel completed, causing an
exception.

This patch introduces SimpleChannelListener which doesn't include so much
logic and may be a better fit when a channel might succeed or fail depending
on certain circumstances.

Flags: needinfo?(valentin.gosu)
Whiteboard: [necko-triaged][necko-priority-review] → [necko-triaged]
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a81cbe1c5504 Fix racy test_channel_close.js r=necko-reviewers,kershaw

https://hg.mozilla.org/mozilla-central/rev/a81cbe1c5504

Status: REOPENED → RESOLVED
Closed: 8 months ago → 8 months ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: