Closed Bug 1760114 Opened 4 years ago Closed 2 years ago

Intermittent browser/extensions/formautofill/test/unit/test_sync.js | single tracking bug

Categories

(Toolkit :: Form Autofill, task, P3)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: jmaher, Assigned: enndeakin, NeedInfo)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [fxcm-test-debt][stockwell unknown])

Attachments

(1 file)

No description provided.
Severity: -- → S3
Severity: S3 → N/A
Type: defect → task

Update:

There have been 32 failures within the last 7 days:

  • 3 failures on Linux 18.04 x64 WebRender opt
  • 3 failures on OS X 10.15 WebRender opt
  • 1 failure on OS X 10.15 WebRender Shippable opt
  • 14 failures on OS X 11 WebRender Shippable opt
  • 2 failures on Windows 10 x64 2004 WebRender opt
  • 2 failures on Windows 11 x86 22H2 WebRender opt
  • 4 failures on Windows 11 x64 22H2 WebRender opt
  • 1 failure on Windows 11 x64 22H2 WebRender Shippable opt
  • 1 failure on Windows 7 WebRender opt
  • 1 failure on Windows 7 WebRender Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=413463389&repo=mozilla-central&lineNumber=7332

[task 2023-04-23T11:39:57.970Z] 11:39:57     INFO -  TEST-START | browser/extensions/formautofill/test/unit/test_sync.js
[task 2023-04-23T11:39:58.915Z] 11:39:58  WARNING -  TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/unit/test_sync.js | xpcshell return code: 0
[task 2023-04-23T11:39:58.915Z] 11:39:58     INFO -  TEST-INFO took 945ms
[task 2023-04-23T11:39:58.915Z] 11:39:58     INFO -  >>>>>>>
[...]
[task 2023-04-23T11:39:59.143Z] 11:39:59     INFO -  TEST-PASS | browser/extensions/formautofill/test/unit/test_sync.js | test_dedupe_multiple_candidates - [test_dedupe_multiple_candidates : 67] "undefined" == "undefined"
[task 2023-04-23T11:39:59.143Z] 11:39:59     INFO -  TEST-PASS | browser/extensions/formautofill/test/unit/test_sync.js | test_dedupe_multiple_candidates - [test_dedupe_multiple_candidates : 68] true == true
[task 2023-04-23T11:39:59.143Z] 11:39:59  WARNING -  TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/unit/test_sync.js | test_dedupe_multiple_candidates - [test_dedupe_multiple_candidates : 821] A should be marked as syncing - 1 === 0
[task 2023-04-23T11:39:59.144Z] 11:39:59     INFO -  /opt/worker/tasks/task_1682248796/build/tests/xpcshell/tests/browser/extensions/formautofill/test/unit/test_sync.js:test_dedupe_multiple_candidates:821
[task 2023-04-23T11:39:59.144Z] 11:39:59     INFO -  /opt/worker/tasks/task_1682248796/build/tests/xpcshell/head.js:_do_main:238
[task 2023-04-23T11:39:59.144Z] 11:39:59     INFO -  /opt/worker/tasks/task_1682248796/build/tests/xpcshell/head.js:_execute_test:585
[task 2023-04-23T11:39:59.144Z] 11:39:59     INFO -  -e:null:1
[task 2023-04-23T11:39:59.144Z] 11:39:59     INFO -  exiting test

Sergey, can you help us assign this to someone?
Thank you.

Flags: needinfo?(sgalich)
Whiteboard: [stockwell needswork:owner]

I looked at this a bit and I think what it wrong with this test is that the sync code expects last modified times to be rounded to seconds using 'Math.round(time / 10) / 100' rather than just 'time / 1000' which test_sync.js is currently doing. I encountered the same issue with password sync.

Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][fxcm-test-debt]

The patch here seems to improve things but I can still see failures when run locally, likely related to the some change that happened mid-April that caused the frequency to increase dramatically. I am going to land this patch but keep the bug open for further investigation.

Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aee4ff444bad use rounding of dates compatible with sync to fix intermittently failing test, r=credential-management-reviewers,sgalich
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: