1760169 - Ensure proper RTL display in new Spotlight messaging surface

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Meg Viar [:mviar]]

Attachment: Example in Arabic build of 99 Beta

When rendering the new Spotlight messaging component in RTL mode, all images and text are mirrored. See MULTISTAGE_SPOTLIGHT_MESSAGE message in ASRouter as an example. Spotlight uses a bundle with AboutWelcome.jsx. When this component is rendered in the context of the AboutWelcome page, the text and step indicators are rendered RTL as expected without mirroring.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1760169 - Ensure proper RTL display in new Spotlight messaging surface

Comment 2

[Meg Viar [:mviar]]

To recreate go to about:config and set intl.l10n.pseudo to bidi. Then, go to about:newtab#asrouter and open the PB_FOCUS_PROMO. Text and icons are mirrored.

Alternatively, download an Arabic build of release and open the MULTISTAGE_SPOTLIGHT_MESSAGE in asrouter. Text, icons, and the step indicator are mirrored.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dd64c6b1e64
Ensure proper RTL display in new Spotlight messaging surface r=dmose

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8dd64c6b1e64

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly AR locale build (100.0a1 Build ID - 20220331093541) installed on Windows 10 x64, macOS 11.6.4, and Linux Mint 20.2 x64. Now I can confirm that the elements from the "MULTISTAGE_SPOTLIGHT_MESSAGE" respect the specifications from comment 2.