1760176 - Fix sending action messages in IRC

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[Patrick Cloke [:clokep]]

Bug 1747090 broke sending IRC action messages.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch

Comment 2

[Patrick Cloke [:clokep]]

If we're doing another TB 99 beta, would be good to get this fixed for it, otherwise it can ride into 100.

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9268350 [details] [diff] [review]
Patch

Review of attachment 9268350 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick fix, I'll add some tests.

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1760176 - Test IRC message sending. r=clokep

Comment 5

[Patrick Cloke [:clokep]]

The patch from me (attachment 9268350 [details] [diff] [review]) should be applied first, with Martin's tests (https://bugzilla.mozilla.org/attachment.cgi?id=9268458) after.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6dd5283b9adc
Fix sending action (/me) messages from IRC. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/134e10286d93
Test IRC message sending. r=clokep

Comment 7

[Patrick Cloke [:clokep]]

Comment on attachment 9268350 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): bug 1747090
User impact if declined: Sending action/emote messages (using the /me command) is broken for IRC.
Testing completed (on c-c, etc.): This landed on comm-central, Martin and I did some testing manually and Martin added xpcshell tests.
Risk to taking this patch (and alternatives if risky): I don't think this will break anything more if taken.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9268350 [details] [diff] [review]
Patch

[Triage Comment]
Approved for beta

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9268350 [details] [diff] [review]
Patch

[Triage Comment]
uplift not needed, already on beta