1760273 - Simulate adding breakpoint in mochitests to match user workflow.

Status: ASSIGNED

(DevTools :: Debugger, defect, P3)

Description

[Hubert Boma Manilla (:bomsy)]

Currently in most of our tests, we add breakpoints by directly calling the adBreakpoint action https://searchfox.org/mozilla-central/rev/478ecccb085b7efd3c4773edb0480a7b2b16754c/devtools/client/debugger/test/mochitest/shared-head.js#908-912.

This does not match user behaviour and means the whole breakpoint workflow is not fully covered.

One example is that in the user workflow a source must be selected in the UI before the user can click in the gutter to add a breakpoint.
In the tests we can add a breakpoint with out a selected source. e.g https://searchfox.org/mozilla-central/rev/478ecccb085b7efd3c4773edb0480a7b2b16754c/devtools/client/debugger/test/mochitest/browser_dbg-bfcache.js#53. which might cause this breakpoint info to be wrong https://searchfox.org/mozilla-central/rev/478ecccb085b7efd3c4773edb0480a7b2b16754c/devtools/client/debugger/src/actions/breakpoints/modify.js#137-149.

Lets make the test match the user workflow, by always selecting a source and using then using the addBreakpointViaGutter https://searchfox.org/mozilla-central/rev/478ecccb085b7efd3c4773edb0480a7b2b16754c/devtools/client/debugger/test/mochitest/shared-head.js#926-930

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1760273 - [devtools] Switch the tests to add breakpoints from the UI instead of actions

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bomsy, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Hubert Boma Manilla (:bomsy)]

A couple of try failures to fix for this to land, will get back to it soon