1760380 - [wpt-sync] Sync PR 33241 - [renderblocking] Make <link> and <style> consistent in when to be blocking

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33241 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33241
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

[renderblocking] Make <link> and <style> consistent in when to be blocking

This patch makes \<style> use the same conditions as \<link> [1] to decide
whether a pending stylesheet should be blocking or not. This makes the
two elements consistent, and fixes a bug that currently script-inserted
style elements are script-blocking (per spec they shouldn't be).

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/link_style.cc;l=282-286;drc=98cdb728ae59ac1151f4406d426233f86498eedd?q=link_style.cc&ss=chromium%2Fchromium%2Fsrc

Bug: 1271296
Change-Id: I40f2dc4fb0d766ffccbcde720e60dc86e06a5b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533426
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Xiaocheng Hu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#982927}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2c3d03effdbfa0fe775c49c37da5e7f6c52508d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 2

Chrome

OK : 2
PASS: 1
FAIL: 1

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/document-metadata/interactions-of-styling-and-scripting/script-created-link-stylesheet-does-not-block-script.html
Script-created link stylesheet is not script-blocking: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], PASS [GitHub] (Chrome: PASS, Safari: FAIL)
/html/semantics/document-metadata/interactions-of-styling-and-scripting/script-created-style-element-does-not-block-script.html
Script-created style element is not script-blocking: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], PASS [GitHub] (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b73206e4e4e
[wpt PR 33241] - [renderblocking] Make <link> and <style> consistent in when to be blocking, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6ade023dc21f
[wpt PR 33241] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35ab014f9cf8
[wpt PR 33241] - [renderblocking] Make <link> and <style> consistent in when to be blocking, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9c55e7dd44d3
[wpt PR 33241] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/35ab014f9cf8
https://hg.mozilla.org/mozilla-central/rev/9c55e7dd44d3