[mozregression] --addon has no effect for WebExtensions without applications.gecko.id in manifest.json
Categories
(Testing :: mozregression, defect, P3)
Tracking
(Not tracked)
People
(Reporter: kevin, Unassigned)
Details
With mozregression 4.0.18 or current main (d979677), the --addon argument does not work if its argument is a WebExtensions xpi where manifest.json does not contain applications.gecko.id or browser_specific_settings.gecko.id. For example, I'd like to search for a regression involving https://addons.mozilla.org/en-US/firefox/addon/devtools-media-panel/ so I run:
curl -fLO https://addons.mozilla.org/firefox/downloads/file/2990419/devtools_media_panel-2.6-fx.xpi
mozregression --addon devtools_media_panel-2.6-fx.xpi --launch 2022-03-19
However, no installed extensions are listed in about:extensions. The Browser Console includes the following warning:
1647732469183 addons.xpi-utils WARN addMetadata: Add-on 079a30404f48436c1eb8a40288b3b1c76a45c1e7@temporary-addon is invalid: Error: Invalid addon ID: expected addon ID 079a30404f48436c1eb8a40288b3b1c76a45c1e7@temporary-addon, found {68d048f4-9449-4c97-8425-6dac7f743b14} in manifest(resource://gre/modules/addons/XPIDatabase.jsm:2968:15) JS Stack trace: addMetadata@XPIDatabase.jsm:2968:15
processFileChanges@XPIDatabase.jsm:3429:26
checkForChanges@XPIProvider.jsm:3062:55
startup@XPIProvider.jsm:2489:12
callProvider@AddonManager.jsm:232:31
_startProvider@AddonManager.jsm:540:17
startup@AddonManager.jsm:773:14
startup@AddonManager.jsm:3463:26
observe@addonManager.js:78:29
I believe this occurs because mozprofile generates id 079a30404f48436c1eb8a40288b3b1c76a45c1e7@temporary-addon randomly at https://hg.mozilla.org/mozilla-central/file/2a12f437bb386b2a9c4c3228d3c733520eb2938d/testing/mozbase/mozprofile/mozprofile/addons.py#l298 due to missing the manifest.json properties mentioned above then copies the xpi into the extensions directory using that name at https://hg.mozilla.org/mozilla-central/file/2a12f437bb386b2a9c4c3228d3c733520eb2938d/testing/mozbase/mozprofile/mozprofile/addons.py#l174 which is subsequently ignored (and deleted) by Firefox.
It would be great if the --addon option could support these WebExtensions. If support is not feasible, mozregression should probably print a warning or error out with a suitable message to inform users of the issue.
Thanks,
Kevin
|
||
Comment 1•4 years ago
|
||
The severity field is not set for this bug.
:zeid, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Updated•1 year ago
|
Description
•