1760588 - The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: SearchBar_Placeholder_FirefoxFocusPromo.gif

[Notes]:

• I also observed that the “Private Browsing” tab title changes in the “about:privatebrowsing#” name if the page is refreshed after the “Get Firefox Focus” spotlight modal was opened.

[Affected versions]:

• Firefox Nightly 100.0a1 (Build ID: 20220320213921)

[Affected Platforms]:

• macOS 11.6
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the Firefox browser installed and opened.
• Have the “browser.search.region” pref set to “US”.

[Steps to reproduce]:

1. Restart the browser and open a new private window. (Ctrl+Shift+P)
2. Click the “Download Firefox Focus” button from the “Firefox Focus” promo message.
3. Refresh the page.
4. Observe the Search Bar.

[Expected result]:

• The Search Bar is correctly displayed and contains a placeholder.

[Actual result]:

• The Search bar placeholder text is missing.

[Additional notes]:

• This issue is still reproducible after a page refresh.
• This issue is reproducible with all of the Search engines.
• This issue is no longer reproducible when opening a new private tab.
• Attached is a screen recording of the issue.

Comment 1

[Meg Viar [:mviar]]

If the PBM page is refreshed after the Spotlight dialog is shown and dismissed, _isAboutPrivateBrowsing is set to false here in ContentSearchHandoff.js, causing the wrong strings to be selected on update. Fluent can't find those messages, so the search bar shows no text.

The problem originates here in ContentSearchParent.jsm where the current URI spec is about:privatebrowsing# after the refresh. The trailing hash results in isInPrivateBrowsingMode being set to false.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1760588 - The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered

Comment 3

[Meg Viar [:mviar]]

https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#117

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c766d91cf91
The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered r=Mardak

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8c766d91cf91

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 100.0a1 (Build ID: 20220324093615) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The in-content "Search bar" placeholder text remains displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered.