1760623 - Remove the ability to build without OpenPGP support, enable it unconditionally

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert [:KaiE:]]

I suggest that we remove the build time option for disabling OpenPGP,
and in addition, also remove the preference mail.openpgp.enable

These were workarounds during the early phases of implementing this feature, when we couldn't provide the feature in the initial 78.0 release.

Now these settings cause extra maintenance burden, as we implement new OpenPGP features, we'd have to wrap each added control in checks for those flags.

By removing these, we can simplify our development life.

Magnus, do you agree?
Rob, any concerns?

Comment 1

[Rob Lemley [:rjl]]

No objection here.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1760623 - Remove --enable-openpgp configure option.

Comment 3

[Rob Lemley [:rjl]]

That patch just removes the configure option and associated DEFINEs. I'll leave the application code to someone more familiar with it.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: Bug 1760623 - Remove the ability to build without OpenPGP support, enable it unconditionally. r=mkmelin

Comment 5

[Magnus Melin [:mkmelin]]

Agreed.

Comment 6

[Kai Engert [:KaiE:]]

Rob, please ask me for review, so we can proceed with landing. Thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dbdcc389898f
Remove --enable-openpgp configure option. r=kaie
https://hg.mozilla.org/comm-central/rev/47d6ec1c0b04
Remove the ability to build without OpenPGP support, enable it unconditionally. r=mkmelin