[wpt-sync] Sync PR 33290 - [tables] Fix crash when recomputing baselines.
Categories
(Core :: Layout: Tables, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33290 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33290
Details from upstream follow.
Ian Kilpatrick <ikilpatrick@chromium.org> wrote:
[tables] Fix crash when recomputing baselines.
When we use the layout cache-slot for recomputing the row baselines
this can place the layout-tree in an inconsistent state.We have two options to fix this, either use the measure slot (however
this may miss - and potentially also leave tree in inconsistent state?)This fix using the disable-side-effects scope to prevent setting invalid
layout results on the tree.Bug: 1308047
Change-Id: Ic43707ff7704485838e21668aed3c41fd048916aReviewed-on: https://chromium-review.googlesource.com/3540916
WPT-Export-Revision: 4760f36cce3cb75f020e95c6290b2a487fd83136
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f12d64041cc09371622a7cfc571691c6a08bed6e
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3dec2c289bc [wpt PR 33290] - [tables] Fix crash when recomputing baselines., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43da3ec00d2c [wpt PR 33290] - [tables] Fix crash when recomputing baselines., a=testonly
Comment 5•2 years ago
|
||
bugherder |
Description
•