1760819 - [Profile Manager / Wayland] Firefox crashes when creating a new profile while ORCA is running

Status: RESOLVED DUPLICATE of bug 1811637

(Core :: Widget: Gtk, defect, P2)

Description

[Raluca Popovici, Desktop QA]

Affected Platform:
Ubuntu 22.04 Wayland

Affected Version:
Nightly 100.0a1 (2022-03-21)

Steps to reproduce:

1. Turn on ORCA (Super+ALT+S)
2. Double click on Firefox
3. Create a new profile to start Firefox using keyboard

Actual result:
Firefox crashes.

Expected result:
Firefox should be opened without any crashes.

Note: https://crash-stats.mozilla.org/report/index/41eddd2a-462c-4cb0-ae39-e45ff0220322

Comment 1

[James Teh [:Jamie]]

(In reply to Ralu from comment #0)

3. Create a new profile to start Firefox using keyboard

What steps did you take here to create a new profile?

Also, is this a regression or did this always happen on this system?

Comment 2

[Raluca Popovici, Desktop QA]

Note: This only happen when ORCA is on.
Steps:

1. Double click on Firefox in order to open Profile manager
2. Select Create Profile button using keyboard (Tab key) and click enter
3. Select Next button using keyboard (Tab key) and click enter
4. Enter a profile name and select Finish button using keyboard (Tab key) and click enter
5. Select Start Nightly button using keyboard (Tab key) and click enter

Comment 3

[Daniel Bodea [:danibodea]]

In my case, the crash happens after having the profile created, before having the browser opened.
Using this information, I also reproduced it by creating a new prodile from the about:profiles page.

STR

1. Launch the browser
2. Load about:profiles
3. Click "Create a new profile" button
4. In the Create Profile Wizard click "Next"
5. input a profile name in the text input box
6. Click the "Finish" button
   Expected: The browser does not crash.
   Actual: The browser crashes.

After having investigated for a regressor using mozregression:
28:24.67 INFO: No more integration revisions, bisection finished.
28:24.67 INFO: Last good revision: eafe8c1e529825f20fbfacda67d16ec7233c6acb
28:24.67 INFO: First bad revision: 4c78c3f1e3e9bc83f3582c0c69c4524e5f64b331
28:24.67 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eafe8c1e529825f20fbfacda67d16ec7233c6acb&tochange=4c78c3f1e3e9bc83f3582c0c69c4524e5f64b331

Comment 4

[Petruta Horea [:phorea]]

When Firefox is already opened and ORCA is started afterwards, the screen reader won't read anything from browser. This works fine on another apps and also while using canonical Nightly.

Comment 5

[James Teh [:Jamie]]

(In reply to Petruta Horea [:phorea] from comment #4)

When Firefox is already opened and ORCA is started afterwards, the screen reader won't read anything from browser.

This is a different bug 1601840.

Comment 6

[James Teh [:Jamie]]

The regression window suggests bug 1530052, but I don't follow how that could cause this.

Eitan, could you look into this when you get a chance?

Comment 8

[Eitan Isaacson [:eeejay]]

I can't reproduce this crash. Curious that this crash only happens in Ubuntu 22.04 LTS. Looking through the stack this doesn't seem related directly to any of our accessibility code, rather standard gtk/atk interactions. The library versions gtk, atk, and the atk adapter don't have any recent changes on them that would make this happen.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Setting Regressed by field after analyzing regression range found by mozregression in comment #3.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1530052

:heftig, since you are the author of the regressor, bug 1530052, could you take a look?

For more information, please visit auto_nag documentation.

Comment 11

[Jan Alexander Steffens [:heftig]]

I don't know why bug 1530052 would cause this.

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

This crash also reproduces for me whith Firefox 106.0a1 (20220911214030) when quiting Firefox, closing browser console, closing another window on Ubuntu 22.04 while having ORCA screen reader enabled. Crash report: https://crash-stats.mozilla.org/report/index/28077728-84e1-40ce-8bfd-f133a0220912.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1530052

Comment 14

[Pascal Chevrel:pascalc]

Jamie, is that a blocker for our general availability of wayland or not? Thanks

Comment 15

[James Teh [:Jamie]]

If this always happens when a Firefox window is closed with Wayland + Orca, I'd say this is a blocker for shipping Wayland. All the crash reports do seem to suggest Wayland is in use, and from what I've been able to determine, Ubuntu 22.04 switched to Wayland by default, which would explain the significance of Ubuntu 22.04 in this bug.

All of that said, we have no idea what's going on here; see comment 8. No Gecko a11y code shows up in the stack. It looks like some crash in ATK/GTK itself.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 5 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Profile manager is running early and AFAIK uses different widget setup that main Firefox window. Also crash address is 0x0 which looks like we access to something already deleted or not created yet. (beside that it's interesting you're running Wayland on NVIDIA :)).

Looking at:
https://crash-stats.mozilla.org/signature/?product=Firefox&signature=gtk_container_foreach

And detailed deports it really looks like we're accessin released memory as it crashes on 0xe5e5e5e5e5e5e5e5.

Can you please:

1. run ASAN build? see https://firefox-source-docs.mozilla.org/tools/sanitizer/asan.html
2. Run with MOZ_LOG="Widget:5 WidgetPopup5:" env variable, reproduce the crash and attach the log here.

Thanks!

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: terminal_export

Hello Martin! Unfortunately for some reason I can't reproduce the issue while using asan builds (tried optimized/ debug and fuzzing asan) and the issue does not reproduce on either of the builds while running with MOZ_LOG="Widget:5 WidgetPopup5:" env variable.
I have started Firefox 111.0a1 (2023-01-31) with MOZ_LOG="Widget:5 WidgetPopup5:" env variable`, without profile manager and reproduced the issue two times by closing a Firefox window and by closing the browser console. I attached the logs from there. If more information is needed please let me know. Thank you!

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Not Wayland related.