Closed Bug 1760825 Opened 2 months ago Closed 2 months ago

Title of new tab page is not properly updated when live language switching

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
100 Branch
Tracking Status
firefox100 --- verified

People

(Reporter: standard8, Assigned: gregtatum)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file, 2 obsolete files)

Preconditions:

user_pref("intl.multilingual.downloadEnabled", true);
user_pref("intl.multilingual.enabled", true);
user_pref("intl.multilingual.liveReload", true);
Install:
language-pack fr

STR:

  1. Install a firefox Firefox locale, en-us for example (autoset region not that relevant).
  2. Install language packs from the preconditions.
  3. Open about:preferences / Language.
  4. Switch the language to fr.
  5. Open a new tab.
  6. Reload the new tab.
  7. Open a second new tab.

Actual results

  1. The new tab has the English title "New Tab"
  2. The tab has the French title "Nouvel onglet"
  3. The new tab has the English title "New Tab"

Expected results

The French title is used in all instances.

Assignee: nobody → gtatum
Severity: -- → S3
Priority: -- → P1
Blocks: 1761830

This adds a utility to load in string bundles in a way that they can be
invalidated. This fixes the short-term bug for the new tab. Bug 1761830
tracks the work to move this to the other call sites.

Depends on D142254

This text is cached, and so needs invalidating when the app locale is
changed.

Depends on D142255

Attachment #9269734 - Attachment is obsolete: true
Attachment #9269733 - Attachment is obsolete: true
Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0faca4e60dac
Fix New Tab text to change on a live language reload; r=amy
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

Verified as fixed on Firefox 100.0b1 with Mac 11 and Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.