1760825 - Title of new tab page is not properly updated when live language switching

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Mark Banner (:standard8)]

Preconditions:

user_pref("intl.multilingual.downloadEnabled", true);
user_pref("intl.multilingual.enabled", true);
user_pref("intl.multilingual.liveReload", true);
Install:
language-pack fr

STR:

1. Install a firefox Firefox locale, en-us for example (autoset region not that relevant).
2. Install language packs from the preconditions.
3. Open about:preferences / Language.
4. Switch the language to fr.
5. Open a new tab.
6. Reload the new tab.
7. Open a second new tab.

Actual results

5. The new tab has the English title "New Tab"
6. The tab has the French title "Nouvel onglet"
7. The new tab has the English title "New Tab"

Expected results

The French title is used in all instances.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1760825 - Add a defineStringBundleGetter function; r?gijs

This adds a utility to load in string bundles in a way that they can be
invalidated. This fixes the short-term bug for the new tab. Bug 1761830
tracks the work to move this to the other call sites.

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1760825 - Use defineStringBundleGetter in browser.js; r?gijs

Depends on D142254

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1760825 - Fix New Tab text to change on a live language reload; r?amy

This text is cached, and so needs invalidating when the app locale is
changed.

Depends on D142255

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0faca4e60dac
Fix New Tab text to change on a live language reload; r=amy

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0faca4e60dac

Comment 6

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on Firefox 100.0b1 with Mac 11 and Windows 10.