1760889 - Opened files are saved in a location that isn't the default downloads folder (when the default the root of a windows drive)

Status: NEW

(Firefox :: File Handling, defect, P3)

Description

[Yogurt4]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

Download a file (that has Ask Always set for the file type) and select View/Open.

Actual results:

After closing the file, it's left in Downloads (in the user's profile directory).

Expected results:

Download it to the temporary directory where it gets deleted. Previous versions of Firefox did it so.

Comment 1

[Yogurt4]

(Unwritten premise: My default download location is NOT Downloads. So nothing should go into that directory, in the first place.)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::File Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0

Hi,

Thank you for opening this enhancement. I will set this as New and waiting for the developer's opinion about it.
@Yogurt the workaround for this, is to set browser.download.improvements_to_download_panel to false in about:config.
Mozregression points to bug 1732347.

Thanks for your report.

Comment 4

[:Gijs (he/him)]

(In reply to Yogurt4 from comment #1)

(Unwritten premise: My default download location is NOT Downloads. So nothing should go into that directory, in the first place.)

What is the value of these prefs in about:config ?

browser.download.dir
browser.download.lastDir
browser.download.useDownloadDir
browser.download.folderList

?

Comment 5

[:Gijs (he/him)]

To clarify: in 98 the expectation is that we don't use the temp folder anymore for these downloads (see also bug 1738574 and all the many many comments there). What is confusing to me is the suggestion in comment 1 that the directory where the file is stored isn't the directory specified as the default downloads directory in Firefox, so I'm trying to get to the bottom of that.

Comment 6

[Yogurt4]

browser.download.dir = D:
browser.download.lastDir = D:
browser.download.useDownloadDir = true
browser.download.folderList = 2

I've read your comment on the mentioned bug and "My Disappointment Is Immeasurable And My Day Is Ruined". You're basically arguing that Edge is doing it the same way. It may. But it's doing it wrong.
And if you're using Downloads, no matter what directory is set for the download target, then why can one configure it?

But basically that another bug that's more annoying: Temporary downloads don't get cleaned up automatically, ASAP. And not only for PDF files. (Which I don't view with FF's built-in viewer. Just because.)

Comment 7

[:Gijs (he/him)]

(In reply to Yogurt4 from comment #6)

browser.download.dir = D:
browser.download.lastDir = D:
browser.download.useDownloadDir = true
browser.download.folderList = 2

Thanks. Is D: a remote or a local drive?

And if you're using Downloads, no matter what directory is set for the download target, then why can one configure it?

It looks like this specific case is broken - it would have been broken before now, though, I would have thought? Although we changed how opened files are handled, we didn't change how saved files are dealt with much... Perhaps you didn't mind/notice because you never clicked "save" for any downloads, or something?

I have a suspicion as to why it's broken, but I'm away from home at the moment and can't check my Windows machine. Does it work if you configure the default downloads folder to be a subfolder of the D: drive, e.g. D:\ThrowawayDownloads or whatever?

But basically that another bug that's more annoying: Temporary downloads don't get cleaned up automatically, ASAP. And not only for PDF files. (Which I don't view with FF's built-in viewer. Just because.)

That's bug 1759779.

Comment 8

[Yogurt4]

D: is a local drive.

I've created a directory and set it as the default download location: D:\downloads
In this case the temporary downloaded file was saved here ... and left here as junk, see 1759779.

Please note that I use my default download location to keep downloaded files in, and not for throwing them away. Junk - if not cleaned up properly - should go to any of the temporary directories.