1760986 - when coordinatesRelativeToScreen was made async not everything was made to await properly

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Timothy Nikkel (:tnikkel)]

Botond noticed this.

For example, synthesizeNativeWheel awaits coordinatesRelativeToScreen but promiseNativeWheelAndWaitForObserver calls synthesizeNativeWheel and it does not await synthesizeNativeWheel.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1725540

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:hiro, since you are the author of the regressor, bug 1725540, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Timothy Nikkel (:tnikkel)]

We'll get to this when we get to it. No need to needinfo hiro. This is a test only function, so this is cleanup and/or fixing potential intermittents only.

Comment 4

[Timothy Nikkel (:tnikkel)]

We don't need to track this for any releases, it's test related issue that we can't link to any known intermittents yet.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1725540

Comment 6

[Timothy Nikkel (:tnikkel)]

Ugh, I guess the bot won't let me. Restoring the flags to what they were before. Wish we could just get rid of these flags on this bug so we don't waste time, we don't need to track this for a release.

Comment 7

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1760986 - Modify APZ mochitest coordinatesRelativeToScreen callers to use await. r=tnikkel

Make the APZ mochitests use coor coordinatesRelativeToScreen and its callers
properly. When wwas made async not everything was made to await properly.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f292dd5b7893
Modify APZ mochitest coordinatesRelativeToScreen callers to use await. r=tnikkel

Comment 9

[Atila Butkovits]

Backed out for causing failures at test_group_scroll_linked_effect.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/33837286f8d89eb69a7be16c4f30050f8a214ead

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f292dd5b7893f008f5079010af286ff3b674a35d&selectedTaskRun=Av1nE01DSWCritZsaL7TgQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=376555511&repo=autoland&lineNumber=7852

Comment 10

[Dan Robertson (:dlrobertson)]

I was able to reproduce the failure on a local machine. I'm not entirely sure at the moment why the tests fails, but I'll start to do some debugging on the test.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adf2b25deb64
Modify APZ mochitest coordinatesRelativeToScreen callers to use await. r=tnikkel

Comment 12

[Marian-Vasile Laza]

Backed out changeset adf2b25deb64 (Bug 1760986) for causing mochitest fis test failures.
Backout link
Push with failures
Failure Log

Comment 13

[Dan Robertson (:dlrobertson)]

Hmm same test failure, but I'm unable to reproduce this now on my local box now. I think I'll back out the changes to that test for now and create a separate issue to fix the async/await usage in the failing test.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/918ef225713f
Modify APZ mochitest coordinatesRelativeToScreen callers to use await. r=tnikkel

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/918ef225713f

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.