1761089 - Implement readable get file request

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Comment 1

[Jari Jalkanen]

Attachment: Bug 1761089 - Implement readable get file request. r=#dom-storage-reviewers,jesup

Depends on D141498

Comment 2

[Jari Jalkanen]

Attachment: Bug 1761089 - Handle disk access through file manager; r=#dom-storage

Depends on D141945

Comment 3

[Jari Jalkanen]

Attachment: WIP: Bug 1761089 - Handle disk access through file manager.

Depends on D141945

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761089: Add support for getFile() to FileSystemHandles in OPFS r=#dom-storage-reviewers,janv

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7347f48bc82
Handle disk access through file manager. r=jesup

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab5a384b9c47
Backed out 3 changesets (bug 1761089, bug 1761098, bug 1758092) for causing hybrid build bustages. CLOSED TREE

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing hybrid build bustages.
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=438092d03ac4b9c36b52ba455da446afc7e14213&selectedTaskRun=MNuCQzTbQuuh2h2sT66nyQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=384906668&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab5a384b9c47c24255c61e202cb0ad6c7286c33c

Please also have a look over these Android xpcshell failures: https://treeherder.mozilla.org/logviewer?job_id=384910146&repo=autoland
and these geckoview ones: https://treeherder.mozilla.org/logviewer?job_id=384910138&repo=autoland

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e760d699039b
Handle disk access through file manager. r=jesup

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for causing geckoview gtest failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=ed4b0f82a1248bc534d668d2547b775d7eb8556d&selectedTaskRun=Lm3siCDDSRq1o6WfIWdEXg.0

Failure logs:

• gtest: https://treeherder.mozilla.org/logviewer?job_id=384924409&repo=autoland
• xpcshell: https://treeherder.mozilla.org/logviewer?job_id=384927234&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e4e003c975211b3740f877cce46c799b99be5717

Jari, please fix all the failures before relanding, thank you.

(In reply to Cosmin Sabou [:CosminS] from comment #3)

Please also have a look over these Android xpcshell failures: https://treeherder.mozilla.org/logviewer?job_id=384910146&repo=autoland
and these geckoview ones: https://treeherder.mozilla.org/logviewer?job_id=384910138&repo=autoland

Comment 10

[Cosmin Sabou [:CosminS]]

Also these gtest on windows: https://treeherder.mozilla.org/logviewer?job_id=384926980&repo=autoland

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a3654a0696a
Handle disk access through file manager. r=jesup

Comment 12

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1761098, Bug 1758092, Bug 1761089) for causing xpcshell failures on test_basics.js.
Backout link
Push with failures <--> x2
Failure Log

Also:
GTest-1proc Failure Log
13 Failure Log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4976ad4fbc0
Handle disk access through file manager; r=jesup

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f4976ad4fbc0

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D141887	Bug 1761089 - Implement readable get file request. r=#dom-storage-reviewers,jesup	jjalkanen	jesup: Inactive

:jjalkanen, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 16

[Suhaib Mujahid [:suhaib]]

Sorry for the noise, there was a problem with a Bugzilla API that caused the bot to think more people were inactive than normal (bug 1789646).

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb32fa2f7d5
Add support for getFile() to FileSystemHandles in OPFS r=dom-storage-reviewers,jari

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761089: cleanup for getFile() in OPFS r=#dom-storage-reviewers,janv

Comment 19

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on IPCBlobUtils.cpp. CLOSED TREE
Backout link
Push with failureshttps://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=usercancel%2Cretry%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=aeb32fa2f7d5f88ce3fea65a6c7171cce4f2980d
Link to failure log
Failure line : Hit MOZ_CRASH(Unknown type.) at /builds/worker/checkouts/gecko/dom/file/ipc/IPCBlobUtils.cpp:45

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c57f1fdefede
Add support for getFile() to FileSystemHandles in OPFS r=dom-storage-reviewers,jari,janv

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c57f1fdefede

Comment 22

[Jari Jalkanen]

All the patches are published.