Closed
Bug 1761317
Opened 2 years ago
Closed 2 years ago
Remove usage of nsIScriptableUnicodeConverter in SearchUtils.jsm
Categories
(Firefox :: Search, task, P3)
Firefox
Search
Tracking
()
VERIFIED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
nsIScriptableUnicodeConverter is obsolete and it is better to use TextEncoder for what we now need.
Note: test_selectedEngine.js checks hashes are generated with the correct length, but testing the correct value needs to be done manually since the hash depends on the profile name.
For testing this:
- Take a version before the fix and set the default engine to a installed engine from a third party.
- Then check that updating to after the fix retains the selected default engine correctly.
Flags: qe-verify+
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
||
Comment 2•2 years ago
•
|
||
Thank you.
I was able to test the patch successfully following the steps you provided.
Also, no more lint warnings in toolkit/components/search. Yay!
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91dd68f94ccd Remove usage of nsIScriptableUnicodeConverter in SearchUtils.jsm. r=mcheang
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
|
||
Comment 5•2 years ago
|
||
Tested by setting duckduckgo as search engine and upgrade from 98.0 to 100.0.
Search engine was successfully kept.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•