1761473 - Get rid of deprecated downloadToDisk() and `deleteFromDisk()` attachments methods

Status: ASSIGNED

(Firefox :: Remote Settings Client, enhancement)

Description

[Mathieu Leplatre [:leplatrem]]

In Bug 1634127 we made the indexeddb storage for attachments the default behaviour for the download() method, and deprecated the file based one.

In this follow-up bug, we want to remove the downloadToDisk() and deleteFromDisk() methods.

They are currently used in:

• Public Suffix List: this code was disabled because of issues and was kind of abandoned (no current owner)
• CRLite filters, which reads buffers already
• ASMRouter: which downloads a FTL file in the profile for localization of user journey messages
• UrlQuickSuggest which downloads icons

The last two may require some advanced changes in their respective components. Alternatively, we could move/duplicate the writing of the file in the profile folder in those components and maintain the current behaviour.

We should also add migration code (e.g. to BrowserGlue's _migrateUI method) that will delete the obsolete files from the profile

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1761473 - Get rid of deprecated downloadToDisk() attachments method r?acottner