1761480 - [Android] Add support for additional prompt types for GeckoView

Status: NEW

(Remote Protocol :: Marionette, enhancement, P3)

Description

[Olivia Hall [:olivia]]

GeckoView sends the standard simple dialogs, prompt, alert, confirm, used by WebDriver, but it also can send additional prompt types such as choice and datetime.

Some of these additional prompt types occur when a form field is focused. For example, entering a select HTML form field will cause a choice prompt to populate. This can cause unexpected prompts to appear in Marionette, because it isn't a simple dialog.

Presently, only simple dialogs are collected for Marionette to use.

An example test that will cause the unexpected prompt behavior in Marionette, if all prompt types are available, is wpt /css/selectors/focus-visible-002.html. This test will cause a datetime prompt to populate. GeckoViewPrompterParent.jsm has an isDialog property that is currently used to prevent passing on these additional prompt types for Marionette to use.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

After talking to Olivia this list of prompt types should actually cover the remaining work to do.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discussed today in our meeting we want to wait until the webdriver tests are run in CI (bug 1749444). That way we can more easily see how many tests are actually affected and especially which kind of prompts we would have to implement next.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Lots of tests depend on opening a new tab. To get a better view into what's needed here lets have bug 1506782 fixed first.