1761513 - Remove Engine(about:preferences#search) should be disabled for current Default Engine

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: enabled_removal_for_default.jpg

about:preferences#search:
the list of Search Engines allow for removal of search engines.

The preferences UI in this case shouldn't allow for removal of the current set engine.
Even if the removal just hides the engine, the button shouldn't be available for the current set default engine

Comment 1

[:Gijs (he/him)]

Drew, is this expected from the search team's perspective? Presumably disabling the button isn't a big deal in terms of code required, but I don't know what the desired/expected behaviour is here.

Comment 2

[Adrian Florinescu [:aflorinescu]]

(In reply to :Gijs (he/him) from comment #1)

Drew, is this expected from the search team's perspective? Presumably disabling the button isn't a big deal in terms of code required, but I don't know what the desired/expected behaviour is here.

This issue was discussed with :standard8 and it was @his suggestion that the bug to be logged as generic in terms of preferences expectancy rather than filling separate issues (there are some implications when allowing for the current default engine to be hidden.)

Comment 3

[Mark Banner (:standard8)]

I'm not sure where the best place for this is at the moment, but lets move it across to search - there's a set of issues on this UI that we want to address. Ideally that remove option should go away, and be replaced by a different mechanism. However, the intermediate suggestion was that we could disable the button for now to avoid potentially strange effects of changing the default.

Comment 4

[Michael Kohler [:mkohler]]

Attachment: Bug 1761513 - Remove Engine(about:preferences#search) should be disabled for current Default Engine r?standard8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc0042704c87
Remove Engine(about:preferences#search) should be disabled for current Default Engine r=Standard8

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dc0042704c87

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

Hello,
I confirm this enhacement is implemented on Firefox Nightly 104.0a1(build ID: 20220720215202) on Ubuntu 22.04, macOS 12 and Windows 10 64-bits.