[wpt-sync] Sync PR 33375 - [renderblocking] Implement render-blocking for link headers
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33375 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33375
Details from upstream follow.
Xiaocheng Hu <xiaochengh@chromium.org> wrote:
[renderblocking] Implement render-blocking for link headers
This patch implements render-blocking for preload and modulepreload link
headers. It's done by creating a PendingLinkPreload when trying to fetch
the resource, so that we can receive callbacks when the fetch finishes.Since there's no element for a link header, the test case cannot listen
to the 'load' event of any EventTarget. Therefore, this patch also
modifies the test code to allow waiting for the PerformanceEntry for
the link header's url.Bug: 1271296
Change-Id: Ic64d26341516a510079c01dbff0b0196c7ec9f24
Reviewed-on: https://chromium-review.googlesource.com/3551557
WPT-Export-Revision: e436534602afd4238aa0e6a1fed3ca7aa285c4ea
| Assignee | ||
Updated•4 years ago
|
| Assignee | ||
Updated•4 years ago
|
| Assignee | ||
Updated•4 years ago
|
| Assignee | ||
Comment 1•4 years ago
|
||
| Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 16 tests and 2 subtests
Status Summary
Firefox
OK : 13[GitHub] 14[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
PASS : 17[GitHub] 19[Gecko-windows10-64-2004-qr-opt] 20[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug] 21[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug] 22[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview]
FAIL : 10[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview] 11[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, GitHub] 12[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug] 13[Gecko-windows10-64-2004-qr-opt]
TIMEOUT: 5
ERROR : 1
NOTRUN : 8
Chrome
OK : 15
PASS : 29
FAIL : 1
TIMEOUT: 1
ERROR : 1
NOTRUN : 8
Safari
OK : 13
PASS : 21
CRASH : 1
FAIL : 7
TIMEOUT: 4
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/dom/render-blocking/header-inserted-preload-link.tentative.html
Render-blocking web font is applied: FAIL
/html/dom/render-blocking/script-inserted-style-element.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL linked bug:Bug 1761889
/html/dom/render-blocking/script-inserted-stylesheet-link.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL linked bug:Bug 1761889
New Tests That Don't Pass
/html/dom/render-blocking/header-inserted-preload-link.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: FAIL, Safari: PASS)
Render-blocking web font is applied: FAIL (Chrome: PASS, Safari: PASS)
/html/dom/render-blocking/parser-inserted-async-script.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
/html/dom/render-blocking/parser-inserted-defer-script.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
/html/dom/render-blocking/parser-inserted-module-script.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
/html/dom/render-blocking/parser-inserted-preload-link.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, GitHub] (Chrome: PASS, Safari: PASS)
Render-blocking web font is applied: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, GitHub] (Chrome: PASS, Safari: PASS)
/html/dom/render-blocking/render-blocked-apis-by-preload-link.tentative.html: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: ERROR, Safari: CRASH)
Should not flush autofocus candidates when render-blocked: PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT)
Should not run the scroll steps when render-blocked: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug] (Chrome: NOTRUN)
Should not run the update animations and send events steps when render-blocked: NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: NOTRUN)
Should not run animation frame callbacks when render-blocked: FAIL [Gecko-windows10-64-2004-qr-opt], NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug] (Chrome: NOTRUN)
Should not run the update intersection observers step when render-blocked: NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: NOTRUN)
Render-blocking web font is applied: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
Should not run the resize steps when render-blocked: NOTRUN (Chrome: NOTRUN)
Should not run the evaluate media queries and report changes steps when render-blocked: NOTRUN (Chrome: NOTRUN)
Should not run the fullscreen steps when render-blocked: NOTRUN (Chrome: NOTRUN)
The render-blocking web font is applied: NOTRUN (Chrome: NOTRUN)
/html/dom/render-blocking/script-inserted-module-script.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
/html/dom/render-blocking/script-inserted-script.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
/html/dom/render-blocking/script-inserted-style-element.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: PASS)
/html/dom/render-blocking/script-inserted-stylesheet-link.tentative.html
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: PASS)
/html/dom/render-blocking/parser-inserted-modulepreload-link.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
Parser-inserted render-blocking module script is preloaded and evaluated: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/html/dom/render-blocking/script-inserted-modulepreload-link.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Rendering is blocked before render-blocking resources are loaded: FAIL (Chrome: PASS, Safari: FAIL)
Script-inserted render-blocking module script is preloaded and evaluated: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bdb303740ad4
https://hg.mozilla.org/mozilla-central/rev/f9d1b3903b50
Description
•