1761611 - <dialog> element isn't rendered correctly in High Contrast Mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Calixte Denizet (:calixte)]

STR:

• open https://css-tricks.com/some-hands-on-with-the-html-dialog-element/
• in accessibility settings, select a contrast theme
• see how the dialog is rendered in the above page

It always uses the same colors scheme (black border, kind of white in background and black in foreground) whatever the contrast theme is.
It's working correctly in chrome an in edge.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Can you attach an screenshot?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

https://html.spec.whatwg.org/#flow-content-3 has:

  background: white;
  color: black;

And it's in a UA sheet so that's what we do. That should be using a system color instead.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I filed https://github.com/whatwg/html/issues/7754 for this, it should be a matter of updating html.css.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1761611 - Make <dialog> styles use system colors. r=sefeng,morgan

To be landed when https://github.com/whatwg/html/issues/7754 has a resolution,
but I think it should be uncontroversial.

Comment 5

[Anna Yeddi [:ayeddi]]

Attachment: 1761611-Win-HCM-on-Dialog-tag-in-Fx-98.0.1.png

Attached is a screenshot of the existent behavior of Firefox 98.0.1 on Windows 11 with OS-powered HCM "Night Sky" active.

The dialog has white background with black border and foreground colors, while it should be reversed (as seen on the right hand side on the Accessibility > Contrast themes OS dialog.

Note: buttons within the <dialog> are rendered as prescribed by the Win HCM.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f2f77d1e339
Make <dialog> styles use system colors. r=morgan

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33390 for changes under testing/web-platform/tests

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8f2f77d1e339

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot