Open Bug 176166 Opened 18 years ago Updated 11 months ago
IDoc Shell::app Type is not easily extensible
Assignee: adamlock → nobody
QA Contact: adamlock → docshell
Nothing like resurrecting a 16 year old bug... I'm currently converting nsIDocShell const lists to CEnums in bug 1505601, and just ran into APP_TYPE. AFAICT, in m-c we never set AppType to anything but APP_TYPE_UNKNOWN unless it's in tests, and APP_TYPE_MAIL is pretty much invalid for m-c now anyways. It seems like we could remove this. However, c-c still uses APP_TYPE heavily, so removing this from nsIDocShell is going to cause them some friction. :bz, any thoughts on how to handle this?
As you note, c-c relies on appType pretty heavily. That's the only reason it ever existed, in fact. Is there a need to remove it, as opposed to just switching to a CEnum? If so, seems like we need to have some way to indicate the same information...
That said, does c-c ever _read_ the appType? If it just sets it, we can look at the very small number of places in m-c that it gets read and come up with some other ways for c-c to get that behavior. That's sort of what comment 2 was about, I think. It's been a while. ;)
c-c reads it once, from what I can tell. If we came up with another place to put it, we could just convert that too. Either way, for now I'm just converting it to a cenum, and will add a "do not delete" comment there, while leaving this bug open. I'm not really sure trying to get all of the required work synced between gecko and c-c teams would be worth the effort right now. I was mostly curious about how we should deal with an issue of split usage between the repos like this, and wanted to make sure there's notes in the code so someone else doesn't try to clean it up.
(and it's switching to CEnum in bug 1505601)
You need to log in before you can comment on or make changes to this bug.