1761663 - in file included from ../browser/components/shell/nsGNOMEShellService.cpp:25: dbus/dbus-glib.h:3:15: fatal error: dbus/dbus-glib.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[tt_1]

Attachment: firefox-nightly-build.log.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I downloaded latest github sources and compiled them

Actual results:

the compile is broken with this error in dbus-glib:

1:04.36 | ^
1:04.36 In file included from Unified_cpp_accessible_generic0.cpp:47:
1:04.36 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox-100.0/accessible/generic/HyperTextAccessible.cpp:1852:22: note: while referencing 'ranges'
1:04.36 1852 | nsTArray<nsRange*> ranges;
1:04.36 | ^~~~~~
1:04.54 In file included from /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox_build/dist/include/mozilla/GRefPtr.h:16,
1:04.54 from /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox-100.0/browser/components/shell/nsGNOMEShellService.cpp:25:
1:04.54 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox_build/dist/system_wrappers/dbus/dbus-glib.h:3:15: fatal error: dbus/dbus-glib.h: No such file or directory
1:04.54 3 | #include_next <dbus/dbus-glib.h>
1:04.54 | ^~~~~~~~~~~~~~~~~~
1:04.54 compilation terminated.
1:04.55 gmake[4]: *** [/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox-100.0/config/rules.mk:660: nsGNOMEShellService.o] Error 1
1:04.55 gmake[4]: Leaving directory '/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox_build/browser/components/shell'
1:04.55 gmake[3]: *** [/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox-100.0/config/recurse.mk:72: browser/components/shell/target-objects] Error 2
1:04.55 gmake[3]: *** Waiting for unfinished jobs....

Expected results:

I expect the compile to pass through

will attached the compressed build log

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1760839

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1760839, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Are you building with some specific flags like --disable-dbus or so?

Comment 5

[tt_1]

Yes, I do build without dbus support. All other flags are in the build log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5664e4a15c4b
Fix --disable-dbus build.

Comment 7

[tt_1]

thank you for the patch, it solves the initial problem for me, but there is hugh amount of linking errors with references to dbus now:

37:44.63 /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: /var/tmp/portage/www-client/firefox-100.0/work/firefox_build/x86_64-unknown-linux-gnu/release/libgkrust.a(dbus-d1a996d47a9c1893.dbus.459a7590-cgu.0.rcgu.o): in function core::ops::function::FnOnce::call_once{{vtable.shim}}': 37:44.63 dbus.459a7590-cgu.0:(.text._ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17h3bb40079a9f586beE+0x1a): undefined reference todbus_message_get_type'
37:44.63 /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: /var/tmp/portage/www-client/firefox-100.0/work/firefox_build/x86_64-unknown-linux-gnu/release/libgkrust.a(dbus-d1a996d47a9c1893.dbus.459a7590-cgu.0.rcgu.o): in function `alloc::vec::Vec<T,A>::extend_desugared':

Comment 8

[tt_1]

Attachment: error-linking-dbus-nightly.log.gz

the full and compressed build log, the errors are all in the last 1000 lines.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Those errors come from rust callers which my patch didn't touch, so I suspect they are from bug 1760774. Can you file another bug? The audio folks would need to look at that :)

Comment 10

[tt_1]

I will, thanks for directing my

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5664e4a15c4b