1761665 - in file included from ..js/src/jit/AtomicOperations.h:14: src/jit/AtomicOperationsGenerated.h:240:17: error: 'asm' operand has impossible constraints

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[tt_1]

Attachment: firefox-nightly-error-in-js-src.log.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I downloaded latest github sources and compiled them

Actual results:

the compile is broken with this error in js/src:

21:41.15 In file included from /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox-100.0/js/src/jit/AtomicOperations.h:14,
21:41.15 from /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox-100.0/js/src/builtin/AtomicsObject.cpp:24,
21:41.15 from Unified_cpp_js_src0.cpp:11:
21:41.15 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox_build/js/src/jit/AtomicOperationsGenerated.h: In function 'bool atomics_xor(JSContext*, unsigned int, JS::Value*)':
21:41.15 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox_build/js/src/jit/AtomicOperationsGenerated.h:240:17: error: 'asm' operand has impossible constraints
21:41.15 240 | asm volatile (
21:41.15 | ^~~
21:41.15 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-100.0/work/firefox_build/js/src/jit/AtomicOperationsGenerated.h:240:17: error: 'asm' operand has impossible constraints
21:41.15 240 | asm volatile (
21:41.15 | ^~~

Expected results:

I expect the compile to pass without issues

I will attach the compressed build log

I'm on armv7a

Comment 1

[tt_1]

the error was a bit confusing, as js/src/jit/AtomicOperationsGenerated.h does not exist in the source tree of firefox. Its generated by js/src/jit/GenerateAtomicOperations.py file, so my initial assumption is that something is wrong with the latest updates to this file. Maybe since firefox-99 branch

Comment 2

[tt_1]

Attachment: AtomicOperationsGenerated.h

attached for diagnosis, file is generated by GenerateAtomicOperations.py

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine: JIT' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[tt_1]

seems incomplete fix has landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1756347

Comment 5

[tt_1]

this should be extended to include both x86 and arm setup:

https://hg.mozilla.org/mozilla-central/rev/5348a5355b78#l1.418

Comment 6

[Jan de Mooij [:jandem]]

(In reply to tt_1 from comment #5)

this should be extended to include both x86 and arm setup:

https://hg.mozilla.org/mozilla-central/rev/5348a5355b78#l1.418

Does that fix the problem for you?

Comment 7

[tt_1]

this makes spidermonkey compile work for me on arm:

•    if is_gcc and cpu_arch == "x86":
  

•    if is_gcc and cpu_arch in ("x86", "arm"):
  

I barely know what I'm doing here, totally unfamiliar with the javascript engine

Comment 8

[tt_1]

bugzilla automatically formated my message

you need to replace
if is_gcc and cpu_arch == "x86":

with:
if is_gcc and cpu_arch in ("x86", "arm"):

to fix the build error with arm

Comment 9

[tt_1]

Attachment: 0001-add-arm-to-list-of-mozinline.patch

basically do this to make it compile on arm

Comment 10

[tt_1]

oh dang, I finally found the switch to trigger this:

--enable-lto hides this bug - no idea why

--disable-lto lets the bug emerge from the shadows :D

my patch from April still works for me, tested with spidermonkey and gcc on armv7a