176181 - network.cookie.enableForCurrentSessionOnly doesn't work

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jeff Thieleke]

Using the current CVS code.

Steps to reproduce:

1. Go to preferences, enable cookies and enable for the current session options.
2. Remove All Cookies.
2. Go to a site that sets persistant cookies (e.g. www.cnn.com).
3. Exit Phoenix.
4. Start Phoenix and notice that there are cookies present.


I only have the two cookie related prefs in my prefs.js file:

user_pref("network.cookie.enableForCurrentSessionOnly", true);
user_pref("network.cookie.enableForOriginatingWebsiteOnly", true);

Comment 1

[Jeff Thieleke]

Attachment: Fix current session only cookies

This bug is caused by a thinko in COOKIE_RegisterPrefCallbacks, introduced in
Blake's Oct 19 nsCookies.cpp v1.86 check-in.

  cookie_SetLifetimePref(forCurrentSession ? COOKIE_Normal : COOKIE_Trim);

should obviously be:

  cookie_SetLifetimePref(forCurrentSession ? COOKIE_Trim : COOKIE_Normal);

Comment 2

[Jeff Thieleke]

Since this is a major regression and the fix is so simple, nominating for 0.4.

Comment 3

[Blake Ross]

It's not really a "regression" since I was fixing/implementing this among other
cookie prefs, but thanks -- I'll look into it.

Comment 4

[Jeff Thieleke]

> It's not really a "regression" since I was 
> fixing/implementing this among other
> cookie prefs, but thanks -- I'll look into it.

The loss of "current session only cookies" functionality is the regression from
prior versions of Phoenix, not the code change itself.  

Prior to the Oct 19th check-in, it was possible to have all cookies expire at
the end of the session, using the Mozilla-style cookie prefs.  After Oct 19th,
there is no way to limit the cookie lifetime to the current session.

Comment 5

[David Hyatt]

--> me

Comment 6

[David Hyatt]

Fixed.

Comment 7

[Bill Mason]

Verified in 20021029 nightly.