176190 - email_in.pl should support attachments

Status: RESOLVED DUPLICATE of bug 381912

(Bugzilla :: Incoming Email, enhancement)

Description

[Albert Ting]

Hi, I'm unable to make this support attachments.  The script does properly parse
the attachment and store the body with a html link to the attachemtn.  But when
I click on the attachment, bugzila says "attachment not found".

thanks,
Albert

Comment 1

[Bradley Baetz (:bbaetz)]

*** Bug 176189 has been marked as a duplicate of this bug. ***

Comment 2

[Dave Miller [:justdave]]

Is this on your own Bugzilla setup, or here on bugzilla.mozilla.org, or?

If it's your own, what OS is your webserver running on?

Comment 3

[Albert Ting]

I'm running my own setup, on Solaris 2.8.  Apache 1.3.26, MYSQL 3.23.50.
Let me know what other type of info you need.

Comment 4

[Dave Miller [:justdave]]

The text "attachment not found" does not appear anywhere in bugzilla in the 2.16
branch that I can find, nor does it appear in cvs tip (according to grep -r -i).
 What's the exact error message?  And just to clarify, this is when you click on
the attachment description in the attachment listing on show_bug.cgi?

Comment 5

[Albert Ting]

There is a link in the comment section to the attachment.  If I click on the
href, it returns with the error message:  Attachment #2 [details] [diff] does not exist.

Best I can tell, it doesn't add the attachment to the database.

Comment 6

[Dave Miller [:justdave]]

OK, dispite the blatently obvious subject line, I missed the fact it was
bugzilla_email_append.pl you were using.  After a quick scan of the code, I see
that reading attachments from the email was never implemented.  I'm not sure how
you were getting entries in the comment section indicating that there was an
attachment because the data isn't even saved at all, it just tosses it as it
encounters it.  (The current code basically strips the attachments).

Comment 7

[Dave Miller [:justdave]]

*** Bug 190522 has been marked as a duplicate of this bug. ***

Comment 8

[John Williams]

Attachment: refactoring patch to make attachments work

Adding this attachment to get the fix noticed.

This mainly just moves some subroutines between files, so the bug_email.pl
maintainer may want to do the refactoring himself.  Here is what the patch
does:

1) Move the functions storeAttachments and dump_entity from bug_email.pl to
BugzillaEmail.pm  (and delete the duplicated dump_entity from
bugzilla_email_append.pl).

2) Add 'use vars qw(@attachments $test $Body);' to all three files, and remove
the 'my' from their declarations in bug_email.pl (or refactor to eliminate the
need for global variables).

3) Add the following line to bugzilla_email_append.pl right before the call to
./processmail:
my $attaches = storeAttachments( $found_id, $userid );

4) Change "$Comment" to "$Body" in bugzilla_email_append.pl.

Comment 9

[Erik Anderson]

I hate to bring M$ into this, but how are we going to try to handle TNEF
attachments?  I think that there may be Perl libraries that attempt to extract
attachments from TNEF encodings, but otherwise we're gonna be having a lot of
people creating attachments called winmail.dat ...

Comment 10

[Marc Schumann [:Wurblzap]]

Is this a dupe of bug 215514?

Comment 11

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 12

[Frédéric Buclin]

Comment on attachment 112551 [details] [diff] [review]
refactoring patch to make attachments work

bitrotten

Comment 13

[Frédéric Buclin]

Marking this bug as a dupe of bug 381912 which, despite being more recent, has a longer list of comments.