Closed Bug 1761932 Opened 8 months ago Closed 8 months ago

Allow combining scores from different snapshot recommendation sources

Categories

(Toolkit :: Places, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox100 --- wontfix
firefox101 --- fixed

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(6 files)

No description provided.
Priority: -- → P3
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f49ac2d3c923
Remove the unneeded keyframes DB schema check. r=mak
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 100 Branch → ---

The work to filter and select recommendations is somewhat split between
SnapshotSelector and SnapshotScorer right now which can be a little confusing.
This simplifies things a little and makes it a bit more efficient by saying that
the selector is responsible for getting the snapshots from the sources and then
the scorer is reponsible for all the filtering and scoring. They share the
SelectionContext object which tells both what to select.

There are some non-final pieces here that will be improved in the next patch but
this makes most of the changes to how we generate and combine recommendations.

It does not yet sum the source specific scores instead still using the highest
so the same scores show up in tests. The next patch will change the calculation.

Depends on D142791

Attachment #9270655 - Attachment description: WIP: Bug 1761932: Move more of the filtering and scoring related work to SnapshotScorer. → Bug 1761932: Move more of the filtering and scoring related work to SnapshotScorer. r=Standard8
Attachment #9270656 - Attachment description: WIP: Bug 1761932: Expose snapshot recommendation sources as a map. → Bug 1761932: Expose snapshot recommendation sources as a map. r=Standard8
Attachment #9270657 - Attachment description: WIP: Bug 1761932: Call recommendation sources in parallel and apply source-specific weights. → Bug 1761932: Call recommendation sources in parallel and apply source-specific weights. r=Standard8
Attachment #9270658 - Attachment description: WIP: Bug 1761932: Add source scores together when a snapshot is recommended by more than one source. → Bug 1761932: Add source scores together when a snapshot is recommended by more than one source. r=Standard8

Being able to change the source weights allows for selecting different sources depending on the
UI.
This also moves the pref check for whether to use the new recommendations into the selector.

Depends on D142793

Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cfcf640c377
Move more of the filtering and scoring related work to SnapshotScorer. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/2d0fe2980825
Expose snapshot recommendation sources as a map. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/26184f0ae876
Call recommendation sources in parallel and apply source-specific weights. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/658867ec611b
Add source scores together when a snapshot is recommended by more than one source. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/5869c01bdb59
Allow overriding the weight of recommendation sources when creating the selector. r=Standard8
You need to log in before you can comment on or make changes to this bug.