1761957 - toolkit/components/glean/ipc/FOGIPC.cpp:167:3: error: profiler_record_wakeup_count was not declared in this scope

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P3)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Solaris build fails with:

18:44.03 /builds/psumbera/mozilla-central-build/toolkit/components/glean/ipc/FOGIPC.cpp:167:3: error: profiler_record_wakeup_count was not declared in this scope
18:44.03   167 |   profiler_record_wakeup_count(type);
18:44.03       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
18:44.91 In file included from /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerLabels.h:14,
18:44.91                  from /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/GeckoProfiler.h:26,
18:44.91                  from /builds/psumbera/mozilla-central-build/toolkit/xre/EventTracer.cpp:52,
18:44.91                  from Unified_cpp_toolkit_xre0.cpp:47:

The first bad revision is:
changeset: 612640:4e7629195cea
user: Florian Quèze <[e-mail]>
date: Mon Mar 28 15:13:09 2022 -0700
description:
Bug 1759535 - Report thread wake-ups through glean, r=gerald

Differential Revision: https://phabricator.services.mozilla.com/D141050

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Telemetry' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1759535

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:florian, since you are the author of the regressor, bug 1759535, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1761957 - Declare profiler_record_wakeup_count when MOZ_GECKO_PROFILER is not defined to avoid tier3 build failures, r=gerald.

Comment 5

[Petr Sumbera]

The patch works for me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2538fd2c8026
Declare profiler_record_wakeup_count when MOZ_GECKO_PROFILER is not defined to avoid tier3 build failures, r=gerald. DONTBUILD

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2538fd2c8026