1762052 - Multistage spotlight shows 1 fewer steps than expected

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ed Lee :Mardak]

The test multistage spotlight has 4 steps but first screen shows no "current" step and subsequent screens show 3 total steps.

Looks like 1 screen was removed for proton assuming first screen was corner position:
https://searchfox.org/mozilla-central/rev/570f6e5c06b6c8140f53bf104d785a18165212ab/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#320

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1762052 - Multistage spotlight shows 1 fewer steps than expected

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff90826f853a
Multistage spotlight shows 1 fewer steps than expected r=emcminn

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ff90826f853a

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 101.0a1 (Build ID: 20220405212313) and Firefox Beta 100.0b2 (Build ID: 20220405224846) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The "MULTISTAGE_SPOTLIGHT_MESSAGE " message contains four dots at the bottom of the modals indicating the number of screens (four), where the dot of the current screen is blue.
• Depending on the user configuration, the “about:welcome” slides contain the correct number of dots and the dot of the current screen is blue.