Closed Bug 1762052 Opened 11 months ago Closed 10 months ago

Multistage spotlight shows 1 fewer steps than expected

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
100 Branch
Iteration:
100.2 - March 21 - April 1
Tracking Flags:
Tracking Status
firefox100 --- verified
firefox101 --- verified

People

(Reporter: Mardak, Assigned: mviar)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1762052 - Multistage spotlight shows 1 fewer steps than expected
48 bytes, text/x-phabricator-request
Details | Review

The test multistage spotlight has 4 steps but first screen shows no "current" step and subsequent screens show 3 total steps.

Looks like 1 screen was removed for proton assuming first screen was corner position:
https://searchfox.org/mozilla-central/rev/570f6e5c06b6c8140f53bf104d785a18165212ab/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#320

Assignee: nobody → mviar
Target Milestone: --- → 100 Branch
Severity: -- → S3
Iteration: --- → 100.2 - March 21 - April 1
Priority: -- → P1
Pushed by mviar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff90826f853a
Multistage spotlight shows 1 fewer steps than expected r=emcminn

https://hg.mozilla.org/mozilla-central/rev/ff90826f853a

Status: NEW → RESOLVED
Closed: 10 months ago
status-firefox100: --- → fixed
Resolution: --- → FIXED

I‘ve verified this issue using the latest Firefox Nightly 101.0a1 (Build ID: 20220405212313) and Firefox Beta 100.0b2 (Build ID: 20220405224846) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

  • The "MULTISTAGE_SPOTLIGHT_MESSAGE " message contains four dots at the bottom of the modals indicating the number of screens (four), where the dot of the current screen is blue.
  • Depending on the user configuration, the “about:welcome” slides contain the correct number of dots and the dot of the current screen is blue.
Status: RESOLVED → VERIFIED
status-firefox100: fixed → verified
status-firefox101: --- → verified
You need to log in before you can comment on or make changes to this bug.