1762259 - Fix "update" tasks in browser_creditCard_doorhanger.js

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Tim Giles [:tgiles]]

There are a few tasks in browser_creditCard_doorhanger.js that use the update panel instead of the save panel. However, due to the secondary button of the update panel, these tests are waiting for the "add" storage event, instead of waiting for an "update" and/or "notifyUsed" storage event. Since the update panel doesn't have a "do nothing" action, unlike the save panel, these tests should be updated.

Here are the list of tasks that need to be updated:

• test_update_third_party_creditCard_logo
• test_update_generic_creditCard_logo

These tests will need the following fixes:

• change await clickDoorhangerButton(SECONDARY_BUTTON) to await clickDoorhangerButton(MAIN_BUTTON)
• change let onChanged = awaitForStorageChangedEvents("add") to let onChanged = awaitForStorageChangedEvents("update")
  • We might need this to be ("update", "notifyUsed") but I'm not 100% sure, should try combinations of these two and see what works and fails

Comment 1

[samuraix221]

Hey, Tim is anyone working on this bug? also how could I reproduce the error and ill try to work out where the file is. If no one is working on it I can give it a go.

Comment 2

[sayuree]

Attachment: Bug 1762259 - edit tasks in browser_creditCard_doorhanger.r=tgiles

Comment 3

[Tim Giles [:tgiles]]

(In reply to samuraix221 from comment #1)

Hey, Tim is anyone working on this bug? also how could I reproduce the error and ill try to work out where the file is. If no one is working on it I can give it a go.

I was out of the office, but in the future feel free to attach a patch to a bug if there's no patch already assigned and no assignee. Submitting a patch to a bug will assign you to it as you can see from the Phabricator Automation on this bug. Sorry about that.

Comment 4

[sayuree]

Attachment: Bug 1762259 - Added update to tasks in browser_creditCard_doorhanger. r=tgiles

Depends on D143030

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02598ee3f8e0
edit tasks in browser_creditCard_doorhanger.r=tgiles

Comment 6

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/02598ee3f8e0