Closed Bug 1762259 Opened 8 months ago Closed 8 months ago

Fix "update" tasks in browser_creditCard_doorhanger.js

Categories

(Toolkit :: Form Autofill, task, P3)

task

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: tgiles, Assigned: sabina.zaripova, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

There are a few tasks in browser_creditCard_doorhanger.js that use the update panel instead of the save panel. However, due to the secondary button of the update panel, these tests are waiting for the "add" storage event, instead of waiting for an "update" and/or "notifyUsed" storage event. Since the update panel doesn't have a "do nothing" action, unlike the save panel, these tests should be updated.

Here are the list of tasks that need to be updated:

  • test_update_third_party_creditCard_logo
  • test_update_generic_creditCard_logo

These tests will need the following fixes:

  • change await clickDoorhangerButton(SECONDARY_BUTTON) to await clickDoorhangerButton(MAIN_BUTTON)
  • change let onChanged = awaitForStorageChangedEvents("add") to let onChanged = awaitForStorageChangedEvents("update")
    • We might need this to be ("update", "notifyUsed") but I'm not 100% sure, should try combinations of these two and see what works and fails
Mentor: tgiles
Keywords: good-first-bug

Hey, Tim is anyone working on this bug? also how could I reproduce the error and ill try to work out where the file is. If no one is working on it I can give it a go.

Assignee: nobody → sabina.zaripova
Status: NEW → ASSIGNED

(In reply to samuraix221 from comment #1)

Hey, Tim is anyone working on this bug? also how could I reproduce the error and ill try to work out where the file is. If no one is working on it I can give it a go.

I was out of the office, but in the future feel free to attach a patch to a bug if there's no patch already assigned and no assignee. Submitting a patch to a bug will assign you to it as you can see from the Phabricator Automation on this bug. Sorry about that.

Priority: -- → P3
Severity: -- → N/A
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02598ee3f8e0
edit tasks in browser_creditCard_doorhanger.r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Regressions: 1764002
You need to log in before you can comment on or make changes to this bug.