1762366 - Add an `injectImmediately` option in `scripting.executeScript()`

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[William Durand [:willdurand]]

See: https://bugs.chromium.org/p/chromium/issues/detail?id=1217895#c15 (that hasn't landed yet AFAICT)

This is about adding a new injectImmediately param to the ScriptInjection type, which will control the run_at used when executing a script.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1762366 - Add an `injectImmediately` option in `scripting.executeScript()`. r?robwu!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64a0fc3e1e44
Add an `injectImmediately` option in `scripting.executeScript()`. r=robwu

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_ext_scripting_executeScript_injectImmediately.html

• backout: https://hg.mozilla.org/integration/autoland/rev/567e7a511a30141b4a634ddb5d90f510acfc695e
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=es1APyRTQJuEU5JZS6B2fg.0&revision=64a0fc3e1e4409e5323e2e74536bf24cd15c86e4
• failure log: https://treeherder.mozilla.org/logviewer?job_id=375801197&repo=autoland&lineNumber=3778

[task 2022-04-26T11:37:13.662Z] 11:37:13     INFO -  TEST-START | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript_injectImmediately.html
[task 2022-04-26T11:42:27.141Z] 11:42:27     INFO -  Buffered messages logged at 11:37:11
[task 2022-04-26T11:42:27.141Z] 11:42:27     INFO -  add_task | Entering test setup
[task 2022-04-26T11:42:27.141Z] 11:42:27     INFO -  add_task | Leaving test setup
[task 2022-04-26T11:42:27.141Z] 11:42:27     INFO -  add_task | Entering test test_executeScript_injectImmediately
[task 2022-04-26T11:42:27.141Z] 11:42:27     INFO -  Extension loaded
[task 2022-04-26T11:42:27.141Z] 11:42:27     INFO -  Buffered messages finished
[task 2022-04-26T11:42:27.142Z] 11:42:27  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript_injectImmediately.html | Test timed out. -
[task 2022-04-26T11:42:27.142Z] 11:42:27  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript_injectImmediately.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2022-04-26T11:42:27.142Z] 11:42:27     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-04-26T11:42:27.142Z] 11:42:27     INFO -      afterCleanup@SimpleTest/SimpleTest.js:1416:18
[task 2022-04-26T11:42:27.142Z] 11:42:27     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1481:7
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      Async*@toolkit/components/extensions/test/mochitest/head.js:27:18
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      async*executeCleanupFunction@SimpleTest/SimpleTest.js:1487:13
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1497:7
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:229:17
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.143Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      TestRunner.runTests/<@SimpleTest/TestRunner.js:521:16
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      Async*TestRunner.runTests@SimpleTest/TestRunner.js:508:48
[task 2022-04-26T11:42:27.144Z] 11:42:27     INFO -      RunSet.runtests@SimpleTest/setup.js:232:14
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -      RunSet.runall@SimpleTest/setup.js:211:12
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -      hookupTests@SimpleTest/setup.js:308:12
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -  parseTestManifest@http://mochi.test:8888/manifestLibrary.js:51:13
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -  getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:64:28
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -  EventHandlerNonNull*getTestManifest@http://mochi.test:8888/manifestLibrary.js:60:3
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -      hookup@SimpleTest/setup.js:284:20
[task 2022-04-26T11:42:27.145Z] 11:42:27     INFO -  EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&logFile=%2Fdata%2Flocal%2Ftmp%2Ftest_root%2Flogs%2Fmochitest.log&fileLevel=INFO&consoleLevel=INFO&hideResultsTable=1&manifestFile=tests.json&dumpOutputDirectory=%2Fdata%2Flocal%2Ftmp%2Ftest_root:11:1
[task 2022-04-26T11:42:27.146Z] 11:42:27     INFO -  TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript_injectImmediately.html | took 311673ms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87f3d25ab99b
Add an `injectImmediately` option in `scripting.executeScript()`. r=robwu

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/87f3d25ab99b