1762380 - The PiP Play/Pause button has a border when the PiP window is focused

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: play button.gif

[Affected Versions]:

• Firefox Release 98.0.2 (Build ID: 20220322144853)
• Firefox RC 99.0 (Build ID: 20220328190900)
• Firefox Nightly 100.0a1 (Build ID: 20220330214842)

[Affected Platforms]:

• Windows 10

[Prerequisites]:

• Have Firefox open.

[Steps to reproduce]:

1. Navigate to a page hosting a video (e.g. https://youtu.be/AjWfY7SnMBI)
2. Click the Picture-in-Picture button.
3. Observe the Play/Pause button.

[Expected result]:

• The button does not have a border.

[Actual result]:

• The button has a border around it, as if it is focused.

[Notes]:

• [Windows] Clicking outside the PiP window will make it disappear and clicking inside the PiP window will make it be displayed again.
• [Linux + macOS] The border is no longer displayed if the user clicks either inside or outside the PiP window.
• Attached is a recording of the issue.

Comment 1

[Ania]

It would be nice to fix it for 100, but definitely not critical and can wait until 101.

Comment 2

[Janvi Bajoria [:janvi01]]

Hey, I would like to work on this.

Comment 3

[kpatenio]

(In reply to Janvi Bajoria [:janvi01] from comment #2)

Hey, I would like to work on this.

Hi Janvi, I would submit a patch so that Bugzilla can auto-assign you to the bug. Help with this would be greatly appreciated!

Comment 4

[Janvi Bajoria [:janvi01]]

I noticed, that the control button autofocus property is set to true which is causing a border around the play/pause button.

Hey, I didn't get why you would submit a patch, I should submit one depicting these changes right?
Thanks!

Comment 5

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1762380 - removed pip play/pause button border when the pip window is focused r=#pip-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b19863195e7a
removed pip play/pause button border when the pip window is focused r=mconley

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b19863195e7a

Comment 8

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible. The border is not displayed at all anymore. Tested on Firefox Nightly 101.0a1 (Build ID: 20220406093646) on Windows 10, macOS 11.6 and Linux Mint 20.2.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:janvi01, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[kpatenio]

The patch landed in nightly and beta is affected.
:janvi01, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

For clarification, this fix does not require an uplift and can stay in the current Nightly version.