1762392 - Add Cocoa platform support for paste files

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Edgar Chen [:edgar]]

GTK already supports this. This bug is filed for making non-e10s work. For content process we also need bug 1308007 get fixed.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1762392 - Part 2: Put utility functions for NSPasteboardItem to nsCocoaUtils; r?spohl

So that we could reuse them in Clipboard code.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1762392 - Part 3: Make Clipboard share the same pasteboard code with DragService;

Depends on D142572

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2861c10481de0ca6fdfe26c8c329266f8b8b7deb

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1762392 - Part 2: Make nsCocoaUtils::TransferableFromPasteboardItem support image types;

Clipboard support image types, borrow the codes there in https://searchfox.org/mozilla-central/source/widget/cocoa/nsClipboard.mm#242-305

Depends on D142572

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1762392 - Part 3: Make Clipboard support pasting file; r?spohl

Depends on D142573

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c9e5e0f424c61d1db807093b8558117ca2bc37b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Tom S [:evilpie]]

It would be nice to have this so we can enable pasting files on all platforms.

Comment 9

[Edgar Chen [:edgar]]

My patches tries to share the code between dnd and clipboard as much as possible, i.e. get data from NSPasteboardItem, but realized that we cannot do that for string data as we currently use the NSPasteboard::stringForType which returns concatenation of the strings from all the items. So I need to revise my patches, I will try to do that later this week or early next week.

Comment 10

[Edgar Chen [:edgar]]

Attachment: Bug 1762392 - Part 1: Move pasteboard type declarations to nsCocoaUtils; r?spohl

Comment 11

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b818713756059107f5b59bbd7e9f5503a3b27cbd

Comment 12

[Stephen A Pohl [:spohl]]

Apologies for the delay here, this fell off my radar. Setting n-i.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8058ade75fd
Part 1: Move pasteboard type declarations to nsCocoaUtils; r=spohl
https://hg.mozilla.org/integration/autoland/rev/2d802e66f41a
Part 2: Put utility functions for NSPasteboardItem to nsCocoaUtils; r=spohl
https://hg.mozilla.org/integration/autoland/rev/4785807571f3
Part 3: Make Clipboard support pasting file; r=spohl

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c8058ade75fd
https://hg.mozilla.org/mozilla-central/rev/2d802e66f41a
https://hg.mozilla.org/mozilla-central/rev/4785807571f3