1762409 - Phase out simd wormhole instructions

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Yury Delendik (:yury)]

We implemented two instructions:

• wasm::SimdOp::MozWHPMADDUBSW to match Intel's vpmaddubsw
• wasm::SimdOp::MozWHPMADDWD to match Intel's vpmaddwd

The latter is just standard wasm::SimdOp::I32x4DotI16x8S. Moving to I32x4DotI16x8S will allow JIT to perform IP-relative-constants optimizations; keeping modifying the logic for MozWHPMADDWD will cause code duplication and maintenance burden.

The MozWHPMADDUBSW is to narrow is specific and intgemm developers were asked to consider moving algorithm to proposed Relaxed Integer Dot Product instructions (see https://github.com/WebAssembly/relaxed-simd/issues/52) to have support for non-Intel platforms.

Comment 1

[Yury Delendik (:yury)]

Intgemm is no longer produces MozWHPMADDWD -- see https://github.com/kpu/intgemm/issues/100

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:florian, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Abhishek]

Adding detailed performance benchmark results

Comment 4

[Yury Delendik (:yury)]

Attachment: Bug 1762409 - Remove wormhole instructions. r?rhunt

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be4721551a07
Remove wormhole instructions. r=rhunt

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/be4721551a07