1762433 - Windows HCM fixes for PBM 100

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Emily McMinn :emcminn]

This bug will address the Windows High Contrast Mode specific issues with the Private Browsing Page for Fx100.

1. the download button should have a border (color: ButtonText) when it is hovered so the text itself doesn’t bleed into the background

2. the border on the close button should use ButtonText

3. the google play and app store buttons in the dialog seem to be images, and the images already have borders so adding the button border like we’d normally makes it look fuzzy/visually indistinct. Ideally I’d remove the border from the image and rely on the CSS styling to add the (dynamic) border back in, but we could also remove the border in HCM since this content wont be adaptive anyway (and I think having the additional border here is actually harming the UX)

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1762433 - Fixes for Windows HCM

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0953982f317
Fixes for Windows HCM r=mviar

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b0953982f317

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (101.0a1 Build ID - 20220415092909) installed on Windows 10 x64 with the "High Contrast Mode" on. Now I can confirm the following:

• The "Download Firefox Focus" button has a border when hovered.
• The border from the "Close" button uses the "ButtonText" color.
• There are no borders on the "Google Play" and "App Store" buttons from the "Get Firefox Focus" modal.