Closed
Bug 1762444
Opened 4 years ago
Closed 4 years ago
Make no-addtask-setup case-insensitive
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(firefox106 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: Gijs, Assigned: mathew.hodson)
References
Details
Attachments
(2 files)
No description provided.
| Reporter | ||
Comment 1•4 years ago
|
||
There are setUp cases at https://searchfox.org/mozilla-central/search?q=function+setUp%28%29&path=&case=true®exp=false, at least.
| Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED
| Assignee | ||
Comment 3•4 years ago
|
||
Depends on D150329
| Comment hidden (off-topic) |
| Reporter | ||
Comment 5•4 years ago
|
||
The bot is very confused. :-(
Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED
Comment 6•4 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:mathew.hodson, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(mathew.hodson)
Flags: needinfo?(gijskruitbosch+bugs)
| Reporter | ||
Comment 7•4 years ago
|
||
I think the patches here need some updates, and they're in a stack where the other patches don't have r+...
Flags: needinfo?(gijskruitbosch+bugs)
Updated•4 years ago
|
Product: Firefox Build System → Developer Infrastructure
| Assignee | ||
Comment 8•4 years ago
|
||
Rebased and added the check-in needed flag.
Flags: needinfo?(mathew.hodson)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/3d4da0ee0120
Replace setUp tasks with add_setup in browser mochitests. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/1845031f2d01
Make no-addtask-setup eslint rule case-insensitive. r=Gijs
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3d4da0ee0120
https://hg.mozilla.org/mozilla-central/rev/1845031f2d01
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•