1762638 - some extensions xpcshell tests fail to run successfully when setting fission preferences

Status: REOPENED

(WebExtensions :: General, task, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 1751492 we are running xpcshell tests with fission by default. They all have a message (extension left running at shutdown) in their errors

toolkit/components/extensions/test/xpcshell/xpcshell-common-e10s.ini

• test_ext_webRequest_filterResponseData.js
• test_ext_webRequest_viewsource_StreamFilter.js

toolkit/components/extensions/test/xpcshell/xpcshell-common.ini

• test_ext_cookieBehaviors.js
• test_ext_content_security_policy.js
• test_ext_contentscript_async_loading.js
• test_ext_contentscript_context.js
• test_ext_contentscript_context_isolation.js
• test_ext_contentscript_css.js
• test_ext_runtime_sendMessage.js
• test_ext_scripting_contentScripts_css.js
• test_ext_userScripts_register.js

toolkit/components/extensions/test/xpcshell/xpcshell-content.ini

• test_ext_contentscript_triggeringPrincipal.js
• test_ext_contentScripts_register.js
• test_ext_web_accessible_resources.js

Comment 1

[Andrew McCreight [:mccr8] (PTO until 12-2)]

For what it is worth, I tried looking at one of these failures, but I didn't really get anywhere because I'm not familiar with this code. Looking at test_ext_webRequest_viewsource_StreamFilter.js, it looked like in StreamFilter::Connect() the promise from the StreamFilterParent::Create() part of the code was getting rejected for some reason. I started messing with MozPromise logging to figure out why that was happening.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1762638 - disable 2 xpcshell tests on macOS debug with fission enabled. r=jmaher

These started to fail after they got turned on for fission in bug 1751492.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/006d2ee8b66e
disable 2 xpcshell tests on macOS debug with fission enabled. r=jmaher DONTBUILD

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/006d2ee8b66e

Comment 6

[Andrew McCreight [:mccr8] (PTO until 12-2)]

The patch that landed just disabled a few more tests.

Comment 7

[Intermittent Failures Robot]

8 failures in 2948 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8

Platform and build breakdown:

• macosx1015-64-qr: 8
  • debug: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1762638&startday=2022-04-11&endday=2022-04-17&tree=all

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 9

[Andrew McCreight [:mccr8] (PTO until 12-2)]

This bug never got fixed. The bot just decided to add an invalid crash signature, then later closed the bug because the invalid crash signature wasn't happening.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:zombie, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 11

[Rob Wu [:robwu]]

Still relevant: https://searchfox.org/mozilla-central/search?q=bug+1762638&path=&case=false&regexp=false