Open Bug 1762638 Opened 2 years ago Updated 1 year ago

some extensions xpcshell tests fail to run successfully when setting fission preferences

Categories

(WebExtensions :: General, task, P3)

task

Tracking

(Not tracked)

REOPENED
101 Branch

People

(Reporter: jmaher, Assigned: zombie, NeedInfo)

References

Details

(Keywords: leave-open, Whiteboard: [addons-jira])

Attachments

(1 file)

in bug 1751492 we are running xpcshell tests with fission by default. They all have a message (extension left running at shutdown) in their errors

toolkit/components/extensions/test/xpcshell/xpcshell-common-e10s.ini

  • test_ext_webRequest_filterResponseData.js
  • test_ext_webRequest_viewsource_StreamFilter.js

toolkit/components/extensions/test/xpcshell/xpcshell-common.ini

  • test_ext_cookieBehaviors.js
  • test_ext_content_security_policy.js
  • test_ext_contentscript_async_loading.js
  • test_ext_contentscript_context.js
  • test_ext_contentscript_context_isolation.js
  • test_ext_contentscript_css.js
  • test_ext_runtime_sendMessage.js
  • test_ext_scripting_contentScripts_css.js
  • test_ext_userScripts_register.js

toolkit/components/extensions/test/xpcshell/xpcshell-content.ini

  • test_ext_contentscript_triggeringPrincipal.js
  • test_ext_contentScripts_register.js
  • test_ext_web_accessible_resources.js
Assignee: nobody → tomica
Severity: -- → N/A
Type: defect → task
Priority: -- → P3
Whiteboard: [addons-jira]

For what it is worth, I tried looking at one of these failures, but I didn't really get anywhere because I'm not familiar with this code. Looking at test_ext_webRequest_viewsource_StreamFilter.js, it looked like in StreamFilter::Connect() the promise from the StreamFilterParent::Create() part of the code was getting rejected for some reason. I started messing with MozPromise logging to figure out why that was happening.

Crash Signature: [@ NS_DispatchToMainThread(already_AddRefed<nsIRunnable>&&, unsigned int)]
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/006d2ee8b66e
disable 2 xpcshell tests on macOS debug with fission enabled. r=jmaher DONTBUILD
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

The patch that landed just disabled a few more tests.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

Closing because no crashes reported for 12 weeks.

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → WORKSFORME

This bug never got fixed. The bot just decided to add an invalid crash signature, then later closed the bug because the invalid crash signature wasn't happening.

Status: RESOLVED → REOPENED
Crash Signature: [@ NS_DispatchToMainThread(already_AddRefed<nsIRunnable>&&, unsigned int)]
Keywords: leave-open
Resolution: WORKSFORME → ---

The leave-open keyword is there and there is no activity for 6 months.
:zombie, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(tomica)
You need to log in before you can comment on or make changes to this bug.