1762804 - Phabricator did not send me an important notification email

Status: NEW

(Conduit :: Phabricator, defect, P3)

Description

[Botond Ballo [:botond]]

Attachment: Screenshot of relevant part of timeline

In the review https://phabricator.services.mozilla.com/D139775, please note the screenshotted section of the timeline. It contains the following events:

1. 4:55 PM: I reviewed the patch and requested changes, changing its state to "Changes Requested".
2. 6:09 PM: The patch author uploaded a new revision addressing my comments, changing the state back to "Needs Review".
   --> I did not get a notification email for this
3. 6:26 PM: Reviewbot reported code analysis results on the new revision.

While I did get a notification email for event #3, I did not get one for event #2, which is an important one (it tells me I need to review the patch again).

Comment 1

[Zeid [:zeid]]

Needs further check (e.g. checking the logs) to figure out if this is a one time error or if it's a more serious issue affecting a certain workflow.

Comment 2

[Mark Banner (:standard8)]

Maybe similar case, I never received email for the "review granted" case here: https://phabricator.services.mozilla.com/D152196#4996121

I'd received the previous emails, but not that last one. I only realised it was approved when I was going back to it to double-check the status.

Comment 3

[Botond Ballo [:botond]]

Another instance: I did not get email notifications about the following patch updates:

https://phabricator.services.mozilla.com/D163801#5390859
https://phabricator.services.mozilla.com/D163801#5391159
https://phabricator.services.mozilla.com/D163801#5391277

which updated a patch I reviewed after it was backed out (to address the reason for the backout).

Comment 4

[Botond Ballo [:botond]]

(Ignore previous comment, on second look those emails are there and read. May have just been a PEBKAC of me not noticing additional emails in the gmail thread.)

Comment 5

[Mark Banner (:standard8)]

Another similar instance, i have not received any emails for https://phabricator.services.mozilla.com/D178296 - I wouldn't expect the ones before it was made public, but I did not receive the comments about granting approval & the follow-up comment.

Comment 6

[David Lawrence [:dkl]]

(In reply to Mark Banner (:standard8) from comment #5)

Another similar instance, i have not received any emails for https://phabricator.services.mozilla.com/D178296 - I wouldn't expect the ones before it was made public, but I did not receive the comments about granting approval & the follow-up comment.

This was due to an error where the latest cursor position in the email system database was pointing to an invalid value in the Phabricator database. By manually incrementing the cursor to the next value in the email systems database, it is able to continue past the error.

We are working on improving the monitoring so that as soon as this error occurs, I and CloudOps are notified of the error and I can get to it right away.

Comment 7

[Botond Ballo [:botond]]

This just happened again: I did not get a Phabricator email about this comment.

Comment 8

[Botond Ballo [:botond]]

Happened again: I did not get a Phabricator email about this update.