1762867 - New window opened after unplugging from dock (with two external monitors) dont show up on Ubuntu 22.04

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[:gerard-majax]

STR:

1. Ubuntu 22.04 with Ubuntu Wayland session ; two external monitors plugged via docking station, main laptop screen is disabled when docked
2. mozilla-central
3. mach run
4. Unplug dock/external monitors
5. Click menu, Open new window or Open new private window

Expected:
I see a new window

Actual:
I dont see anything

Other GTK apps (gedit) behaves fine. Thunderbird (Daily) also repro.
The window seems to be created somehow but not visible, because when trying to close the only visible window, the process does not exit gracefully and is waiting on some processes.

Comment 1

[:gerard-majax]

Attachment: running without unplugging, no problem

Comment 2

[:gerard-majax]

Attachment: running with unplugging, repro

Comment 3

[:gerard-majax]

This Pernosco session reproduces the issue: https://pernos.co/debug/tYrKJgiInFEe7-DXbmuWxw/index.html

Comment 4

[:gerard-majax]

Attachment: about:support

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Looks like we failed to load monitor setup:

[ 670876.313] [e-mail](0, 0, 310, 170, 0, "CSO", "0x1407", 0)
[ 670876.342] [e-mail](3, 3840, 2160, 60000)
[ 670876.379] [e-mail](2)
[ 670876.383] [e-mail]()
[ 671079.772] [e-mail]_position(0, 0)
[ 671079.776] [e-mail]_size(2560, 1440)
[ 671079.778] [e-mail]("eDP-1")
[ 671079.781] [e-mail]("Affichage intégré")
[ 671079.783] [e-mail]()
[ 671079.915] [e-mail]_position(0, 0)
[ 671079.921] [e-mail]_size(2560, 1440)
[ 671079.923] [e-mail]()
[ 671079.931] [e-mail]()
2022-04-04 09:57:29.281024 UTC - [Parent 2461020: Main Thread]: D/WidgetScreen done
2022-04-04 09:57:29.281029 UTC - [Parent 2461020: Main Thread]: D/WidgetScreen Refreshing screens
2022-04-04 09:57:29.281037 UTC - [Parent 2461020: Main Thread]: D/WidgetScreen Monitor 0 [0 0 -> 0 x 0 depth 32 content scale 0.000000 css scale 0.000000 DPI 96.000000]

so we end up with monitor 0,0 pixels large :)

Comment 6

[:gerard-majax]

  2022-04-04 17:02:27.681244 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen Add Monitor ID 115 num 1
  2022-04-04 17:02:27.681247 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen Added Monitor 7fe41b20b840 ID 115 num 2
  2022-04-04 17:02:27.681249 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen mMonitors[0]=7fe41b20b800 => id=113
  2022-04-04 17:02:27.681251 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen mMonitors[1]=7fe41b20b820 => id=114
  2022-04-04 17:02:27.681253 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen mMonitors[2]=7fe41b20b840 => id=115

  2022-04-04 17:02:27.918968 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: geometry position 0 0 physical size 310 170
  2022-04-04 17:02:27.918989 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: monitor:7fe41b20b840 (115) mode output size 3840 x 2160 refresh 60000
  2022-04-04 17:02:27.918993 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: monitor:7fe41b20b840 (115) set values mode output size 3840 x 2160 refresh 60000
  2022-04-04 17:02:27.918997 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: scale 2
  2022-04-04 17:02:27.919000 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen done: 7fe41b20b840

  2022-04-04 17:02:27.919020 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen MakeScreenWayland num=1 aMonitor=0 aId=115 7fe41b20b800
  2022-04-04 17:02:27.919034 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen Monitor 0 [0 0 -> 0 x 0 depth 32 content scale 0.000000 css scale 0.000000 DPI 96.000000]

Comment 7

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #6)

  2022-04-04 17:02:27.681244 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen Add Monitor ID 115 num 1
  2022-04-04 17:02:27.681247 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen Added Monitor 7fe41b20b840 ID 115 num 2
  2022-04-04 17:02:27.681249 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen mMonitors[0]=7fe41b20b800 => id=113
  2022-04-04 17:02:27.681251 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen mMonitors[1]=7fe41b20b820 => id=114
  2022-04-04 17:02:27.681253 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen mMonitors[2]=7fe41b20b840 => id=115

  2022-04-04 17:02:27.918968 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: geometry position 0 0 physical size 310 170
  2022-04-04 17:02:27.918989 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: monitor:7fe41b20b840 (115) mode output size 3840 x 2160 refresh 60000
  2022-04-04 17:02:27.918993 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: monitor:7fe41b20b840 (115) set values mode output size 3840 x 2160 refresh 60000
  2022-04-04 17:02:27.918997 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen wl_output: scale 2
  2022-04-04 17:02:27.919000 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen done: 7fe41b20b840

  2022-04-04 17:02:27.919020 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen MakeScreenWayland num=1 aMonitor=0 aId=115 7fe41b20b800
  2022-04-04 17:02:27.919034 UTC - [Parent 2686628: Main Thread]: D/WidgetScreen Monitor 0 [0 0 -> 0 x 0 depth 32 content scale 0.000000 css scale 0.000000 DPI 96.000000]

So when we unplug and move from 2x external monitors to one laptop screen, we:

• Add Monitor ID 115 => 7fe41b20b840
  • mMonitors[0]=7fe41b20b800
  • mMonitors[1]=7fe41b20b820
  • mMonitors[2]=7fe41b20b840
    => We have MonitorConfig* data for wayland listeners that points to mMonitors[2]
• We get two consecutives RemoveMonitorConfig
  • mMonitors[0]=7fe41b20b800
    => Now, our ID=115 is 7fe41b20b800
• wl_output listener comes in, it tries to use 7fe41b20b840 which seems to be still valid (because of the mentionned TODO leak?)
• So we dont update the correct value with the new resolution infos.

NOT performing the array remove at https://searchfox.org/mozilla-central/rev/26a1b0fce12e6dd495a954c542bb1e7bd6e0d548/widget/gtk/ScreenHelperGTK.cpp#306 we can open a window.

Comment 8

[:gerard-majax]

Attachment: Bug 1762867 - Update correct wayland MonitorConfig r?stransky!,emilio!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/245305794760
Update correct wayland MonitorConfig r=emilio

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/245305794760

Comment 11

[:gerard-majax]

after a few days on nightly we should probably request uplift

Comment 12

[:gerard-majax]

So installing a VM locally, unfortunately, KVM / virt-manager does not offer hotplug of monitors, so I can't really verify again.
Several colleagues could not reproduce as well, so my guess is that it depends on the physical setup.

Mine is two external monitors connected over display port, with a KVM switch, then wired to a ThinkPad docking station connected to my laptop. When the laptop is "docked", its internal screen is turned off and only the two external monitors are used. When I undock, laptop main screen takes precedence obviously, and on a lower level the chain of event is:

• Add monitor (laptop screen)
• Remove monitor (one external monitor)
• Remove monitor (one external monitor)

Olivier, you might want to know about that bug in case you get reports in the wild, we could uplift. But so far I wont request uplift.

Comment 13

[Olivier Tilloy]

Ack, thanks for the heads up Alexandre.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 16

[Manuel Bucher [:manuel]]

I've experienced this crash on firefox 103: https://crash-stats.mozilla.org/report/index/791812db-df8a-4673-a7cb-277600220801#tab-details

Slightly different STR:

1. having firefox running
2. open laptop lid (+1 montor)
3. unplug usb-c hub (-1 monitor)
4. firefox crashes

System: Gnome 42.3 on Wayland, Arch Linux