1762900 - Start picture in picture button is not displayed properly when focused

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Neil Deakin]

1. Open a page with a video, for example, https://pauljadam.com/demos/html5-video-a11y.html
2. Press the Play button to start the video.
3. Use the Tab key to focus the pitcure-in-picture button

Expected:
The picture in picture button should be visible with a focus ring around it.

Actual:

1. The button only displays while the mouse is hovered over the video
2. The focus indicator appears to be unsized, just a blue dot in the upper left of the button, rather than around the entire button.

Comment 1

[av]

Hi there,

Would you be able to point to the appropriate files related to this issue?

Thank you

Comment 2

[Cieara Meador [:cmkm]]

Attachment: Bug 1762900 - Show PiP toggle button on keyboard focus r?#pip-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57e0683b60e2
Show PiP toggle button on keyboard focus r=pip-reviewers,desktop-theme-reviewers,mhowell,Itiel

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/57e0683b60e2

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-02-05 Nightly build on macOS 12.
Verified as fixed on Firefox 111.0b3(build ID: 20230219190218) and Nightly 112.0a1(build ID: 20230220165121) on macOS 12, Windows 10, Ubuntu 22.